Skip to content

Commit

Permalink
fix(controller): Support emissary on Windows (#5203)
Browse files Browse the repository at this point in the history
Signed-off-by: Markus Lippert <lippertmarkus@gmx.de>
  • Loading branch information
lippertmarkus authored Feb 25, 2021
1 parent 8acdb1b commit 47ac323
Show file tree
Hide file tree
Showing 5 changed files with 11 additions and 156 deletions.
3 changes: 1 addition & 2 deletions cmd/argoexec/commands/emissary.go
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ import (
"github.com/argoproj/argo-workflows/v3/util/archive"
"github.com/argoproj/argo-workflows/v3/workflow/common"
osspecific "github.com/argoproj/argo-workflows/v3/workflow/executor/os-specific"
"github.com/argoproj/argo-workflows/v3/workflow/util/path"
)

var (
Expand Down Expand Up @@ -74,7 +73,7 @@ func NewEmissaryCommand() *cobra.Command {
return fmt.Errorf("failed to unmarshal template: %w", err)
}

name, err = path.Search(name)
name, err = exec.LookPath(name)
if err != nil {
return fmt.Errorf("failed to find name in PATH: %w", err)
}
Expand Down
4 changes: 2 additions & 2 deletions go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ require (
github.com/aliyun/aliyun-oss-go-sdk v2.1.5+incompatible
github.com/antonmedv/expr v1.8.8
github.com/argoproj/argo-events v1.2.0
github.com/argoproj/pkg v0.4.0
github.com/argoproj/pkg v0.5.0
github.com/baiyubin/aliyun-sts-go-sdk v0.0.0-20180326062324-cfa1a18b161f // indirect
github.com/blushft/go-diagrams v0.0.0-20201006005127-c78c821223d9
github.com/colinmarc/hdfs v1.1.4-0.20180805212432-9746310a4d31
Expand Down Expand Up @@ -74,7 +74,7 @@ require (
k8s.io/client-go v0.19.6
k8s.io/code-generator v0.19.6
k8s.io/gengo v0.0.0-20201214224949-b6c5ce23f027 // indirect
k8s.io/klog/v2 v2.4.0
k8s.io/klog/v2 v2.5.0
k8s.io/kube-openapi v0.0.0-20201113171705-d219536bb9fd
k8s.io/utils v0.0.0-20201110183641-67b214c5f920
sigs.k8s.io/controller-tools v0.4.1
Expand Down
Loading

0 comments on commit 47ac323

Please sign in to comment.