Skip to content

Commit

Permalink
fix(plugins): UX improvements (#8122)
Browse files Browse the repository at this point in the history
* fix(plugins): set Content-Type request header

Signed-off-by: Felix Seidel <felix@seidel.me>

* fix(plugins): keep namespace from plugin manifest

Signed-off-by: Felix Seidel <felix@seidel.me>
  • Loading branch information
Shark authored and sarabala1979 committed Mar 18, 2022
1 parent ea36c33 commit 47b78d4
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions workflow/util/plugins/configmap.go
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ func ToConfigMap(p *spec.Plugin) (*apiv1.ConfigMap, error) {
Labels: map[string]string{
common.LabelKeyConfigMapType: p.Kind,
},
Namespace: p.Namespace,
},
Data: map[string]string{
"sidecar.container": string(data),
Expand Down
1 change: 1 addition & 0 deletions workflow/util/plugins/plugin.go
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ func (p *Client) Call(ctx context.Context, method string, args interface{}, repl
if err != nil {
return err
}
req.Header["Content-Type"] = []string{"application/json"}
resp, err := p.client.Do(req)
if err != nil {
return err
Expand Down

0 comments on commit 47b78d4

Please sign in to comment.