fix: Fix the TestStopBehavior flackiness (#8096)

Signed-off-by: Saravanan Balasubramanian <sarabala1979@gmail.com>
argoproj · Mar 8, 2022 · 4d48904 · 4d48904
1 parent b80b425
commit 4d48904
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/pkg/apis/workflow/v1alpha1/workflow_types.go b/pkg/apis/workflow/v1alpha1/workflow_types.go
@@ -1934,6 +1934,11 @@ func (n NodeStatus) IsDaemoned() bool {
 	return true
 }
 
+// IsExitNode returns whether or not node run as exit handler.
+func (ws NodeStatus) IsExitNode() bool {
+	return strings.HasSuffix(ws.DisplayName, ".onExit")
+}
+
 func (n NodeStatus) Succeeded() bool {
 	return n.Phase == NodeSucceeded
 }

diff --git a/workflow/controller/exec_control.go b/workflow/controller/exec_control.go
@@ -81,7 +81,7 @@ func (woc *wfOperationCtx) handleExecutionControlError(nodeID string, wfNodesLoc
 	// then need to fail child nodes so they will not hang in Pending after pod deletion
 	for _, nodeID := range node.Children {
 		child := woc.wf.Status.Nodes[nodeID]
-		if !child.Fulfilled() {
+		if !child.IsExitNode() && !child.Fulfilled() {
 			woc.markNodePhase(child.Name, wfv1.NodeFailed, errorMsg)
 		}
 	}