fix: Fix rowserrcheck lint errors (#7924)

Signed-off-by: Alex Collins <alex_collins@intuit.com>
argoproj · Feb 18, 2022 · 5b6bfb6 · 5b6bfb6
1 parent 9fb3cb7
commit 5b6bfb6
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/persist/sqldb/backfill_nodes.go b/persist/sqldb/backfill_nodes.go
@@ -37,6 +37,9 @@ func (s backfillNodes) apply(session sqlbuilder.Database) (err error) {
 	}()
 
 	for rs.Next() {
+		if err := rs.Err(); err != nil {
+			return err
+		}
 		workflow := ""
 		err := rs.Scan(&workflow)
 		if err != nil {

diff --git a/persist/sqldb/migrate.go b/persist/sqldb/migrate.go
@@ -55,6 +55,8 @@ func (m migrate) Exec(ctx context.Context) (err error) {
 			if err != nil {
 				return err
 			}
+		} else if err := rs.Err(); err != nil {
+			return err
 		}
 	}
 	dbType := dbTypeFor(m.session)