Skip to content

Commit

Permalink
feat: add ArtifactGC to template spec (#8493)
Browse files Browse the repository at this point in the history 
Signed-off-by: Dillen Padhiar <dpadhiar99@gmail.com>
  • Loading branch information
@dpadhiar
dpadhiar committed Apr 26, 2022
1 parent 19e763a commit 6769ba7
Show file tree
Hide file tree
Showing 21 changed files with 874 additions and 592 deletions.
2 changes: 1 addition & 1 deletion Makefile
View file
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@

export SHELL:=/bin/bash
export SHELLOPTS:=$(if $(SHELLOPTS),$(SHELLOPTS):)pipefail:errexit

# https://stackoverflow.com/questions/4122831/disable-make-builtin-rules-and-variables-from-inside-the-make-file
Expand Down
4 changes: 4 additions & 0 deletions api/jsonschema/schema.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7170,6 +7170,10 @@
"$ref": "#/definitions/io.argoproj.workflow.v1alpha1.ArtifactLocation",
"description": "Location in which all files related to the step will be stored (logs, artifacts, etc...). Can be overridden by individual items in Outputs. If omitted, will use the default artifact repository location configured in the controller, appended with the \u003cworkflowname\u003e/\u003cnodename\u003e in the key."
},
"artifactGC": {
"$ref": "#/definitions/io.argoproj.workflow.v1alpha1.ArtifactGC",
"description": "ArtifactGC describes the strategy to use when to deleting artifacts from executed templates"
},
"automountServiceAccountToken": {
"description": "AutomountServiceAccountToken indicates whether a service account token should be automatically mounted in pods. ServiceAccountName of ExecutorConfig must be specified if this value is false.",
"type": "boolean"
Expand Down
4 changes: 4 additions & 0 deletions api/openapi-spec/swagger.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -11517,6 +11517,10 @@
"description": "Location in which all files related to the step will be stored (logs, artifacts, etc...). Can be overridden by individual items in Outputs. If omitted, will use the default artifact repository location configured in the controller, appended with the \u003cworkflowname\u003e/\u003cnodename\u003e in the key.",
"$ref": "#/definitions/io.argoproj.workflow.v1alpha1.ArtifactLocation"
},
"artifactGC": {
"description": "ArtifactGC describes the strategy to use when to deleting artifacts from executed templates",
"$ref": "#/definitions/io.argoproj.workflow.v1alpha1.ArtifactGC"
},
"automountServiceAccountToken": {
"description": "AutomountServiceAccountToken indicates whether a service account token should be automatically mounted in pods. ServiceAccountName of ExecutorConfig must be specified if this value is false.",
"type": "boolean"
Expand Down
1 change: 1 addition & 0 deletions docs/fields.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1596,6 +1596,7 @@ Template is a reusable and composable unit of execution in a workflow
|`activeDeadlineSeconds`|[`IntOrString`](#intorstring)|Optional duration in seconds relative to the StartTime that the pod may be active on a node before the system actively tries to terminate the pod; value must be positive integer This field is only applicable to container and script templates.|
|`affinity`|[`Affinity`](#affinity)|Affinity sets the pod's scheduling constraints Overrides the affinity set at the workflow level (if any)|
|`archiveLocation`|[`ArtifactLocation`](#artifactlocation)|Location in which all files related to the step will be stored (logs, artifacts, etc...). Can be overridden by individual items in Outputs. If omitted, will use the default artifact repository location configured in the controller, appended with the <workflowname>/<nodename> in the key.|
|`artifactGC`|[`ArtifactGC`](#artifactgc)|ArtifactGC describes the strategy to use when to deleting artifacts from executed templates|
|`automountServiceAccountToken`|`boolean`|AutomountServiceAccountToken indicates whether a service account token should be automatically mounted in pods. ServiceAccountName of ExecutorConfig must be specified if this value is false.|
|`container`|[`Container`](#container)|Container is the main container image to run in the pod|
|`containerSet`|[`ContainerSetTemplate`](#containersettemplate)|ContainerSet groups multiple containers within a single pod.|
Expand Down
18 changes: 18 additions & 0 deletions manifests/base/crds/full/argoproj.io_clusterworkflowtemplates.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2260,6 +2260,15 @@ spec:
type: boolean
type: object
type: object
artifactGC:
properties:
strategy:
enum:
- ""
- OnWorkflowCompletion
- OnWorkflowDeletion
type: string
type: object
automountServiceAccountToken:
type: boolean
container:
Expand Down Expand Up @@ -9077,6 +9086,15 @@ spec:
type: boolean
type: object
type: object
artifactGC:
properties:
strategy:
enum:
- ""
- OnWorkflowCompletion
- OnWorkflowDeletion
type: string
type: object
automountServiceAccountToken:
type: boolean
container:
Expand Down
18 changes: 18 additions & 0 deletions manifests/base/crds/full/argoproj.io_cronworkflows.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2281,6 +2281,15 @@ spec:
type: boolean
type: object
type: object
artifactGC:
properties:
strategy:
enum:
- ""
- OnWorkflowCompletion
- OnWorkflowDeletion
type: string
type: object
automountServiceAccountToken:
type: boolean
container:
Expand Down Expand Up @@ -9098,6 +9107,15 @@ spec:
type: boolean
type: object
type: object
artifactGC:
properties:
strategy:
enum:
- ""
- OnWorkflowCompletion
- OnWorkflowDeletion
type: string
type: object
automountServiceAccountToken:
type: boolean
container:
Expand Down
45 changes: 45 additions & 0 deletions manifests/base/crds/full/argoproj.io_workflows.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2274,6 +2274,15 @@ spec:
type: boolean
type: object
type: object
artifactGC:
properties:
strategy:
enum:
- ""
- OnWorkflowCompletion
- OnWorkflowDeletion
type: string
type: object
automountServiceAccountToken:
type: boolean
container:
Expand Down Expand Up @@ -9091,6 +9100,15 @@ spec:
type: boolean
type: object
type: object
artifactGC:
properties:
strategy:
enum:
- ""
- OnWorkflowCompletion
- OnWorkflowDeletion
type: string
type: object
automountServiceAccountToken:
type: boolean
container:
Expand Down Expand Up @@ -19058,6 +19076,15 @@ spec:
type: boolean
type: object
type: object
artifactGC:
properties:
strategy:
enum:
- ""
- OnWorkflowCompletion
- OnWorkflowDeletion
type: string
type: object
automountServiceAccountToken:
type: boolean
container:
Expand Down Expand Up @@ -27426,6 +27453,15 @@ spec:
type: boolean
type: object
type: object
artifactGC:
properties:
strategy:
enum:
- ""
- OnWorkflowCompletion
- OnWorkflowDeletion
type: string
type: object
automountServiceAccountToken:
type: boolean
container:
Expand Down Expand Up @@ -34243,6 +34279,15 @@ spec:
type: boolean
type: object
type: object
artifactGC:
properties:
strategy:
enum:
- ""
- OnWorkflowCompletion
- OnWorkflowDeletion
type: string
type: object
automountServiceAccountToken:
type: boolean
container:
Expand Down
9 changes: 9 additions & 0 deletions manifests/base/crds/full/argoproj.io_workflowtasksets.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -711,6 +711,15 @@ spec:
type: boolean
type: object
type: object
artifactGC:
properties:
strategy:
enum:
- ""
- OnWorkflowCompletion
- OnWorkflowDeletion
type: string
type: object
automountServiceAccountToken:
type: boolean
container:
Expand Down
18 changes: 18 additions & 0 deletions manifests/base/crds/full/argoproj.io_workflowtemplates.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2259,6 +2259,15 @@ spec:
type: boolean
type: object
type: object
artifactGC:
properties:
strategy:
enum:
- ""
- OnWorkflowCompletion
- OnWorkflowDeletion
type: string
type: object
automountServiceAccountToken:
type: boolean
container:
Expand Down Expand Up @@ -9076,6 +9085,15 @@ spec:
type: boolean
type: object
type: object
artifactGC:
properties:
strategy:
enum:
- ""
- OnWorkflowCompletion
- OnWorkflowDeletion
type: string
type: object
automountServiceAccountToken:
type: boolean
container:
Expand Down
Loading

0 comments on commit 6769ba7

Please sign in to comment.