fix(controller): Enhance output capture (#5450)

Signed-off-by: Alex Collins <alex_collins@intuit.com>

workflow/controller/operator.go

@@ -1158,21 +1158,21 @@ func (woc *wfOperationCtx) assessNodeStatus(pod *apiv1.Pod, node *wfv1.NodeStatu
 			}
 		}
 	}
-	// outputs are mixed between the annotation (parameters, artifacts, and result) and the pod's status (exit code)
-	if exitCode := getExitCode(pod); exitCode != nil {
-		if node.Outputs == nil {
-			node.Outputs = &wfv1.Outputs{}
-		}
-		woc.log.Infof("Updating node %s exit code %v -> %v", node.ID, node.Outputs.ExitCode, *exitCode)
-		if outputStr, ok := pod.Annotations[common.AnnotationKeyOutputs]; ok {
-			woc.log.Infof("Setting node %v outputs: %s", node.ID, outputStr)
-			if err := json.Unmarshal([]byte(outputStr), node.Outputs); err != nil { // I don't expect an error to ever happen in production
-				node.Phase = wfv1.NodeError
-				node.Message = err.Error()
+
+	// we only need to update these values if the container transitions to complete
+	if !node.Phase.Fulfilled() && newPhase.Fulfilled() {
+		// outputs are mixed between the annotation (parameters, artifacts, and result) and the pod's status (exit code)
+		if exitCode := getExitCode(pod); exitCode != nil {
+			woc.log.Infof("Updating node %s exit code %d", node.ID, *exitCode)
+			node.Outputs = &wfv1.Outputs{ExitCode: pointer.StringPtr(fmt.Sprintf("%d", int(*exitCode)))}
+			if outputStr, ok := pod.Annotations[common.AnnotationKeyOutputs]; ok {
+				woc.log.Infof("Setting node %v outputs: %s", node.ID, outputStr)
+				if err := json.Unmarshal([]byte(outputStr), node.Outputs); err != nil { // I don't expect an error to ever happen in production
+					node.Phase = wfv1.NodeError
+					node.Message = err.Error()
+				}
 			}
 		}
-		node.Outputs.ExitCode = pointer.StringPtr(fmt.Sprintf("%d", int(*exitCode)))
-		updated = true
 	}
 
 	if node.Phase != newPhase {