Skip to content

Commit

Permalink
fix: upgrade base image for security and build support arm64 #10435 (#…
Browse files Browse the repository at this point in the history
…11613)

Signed-off-by: Son Bui <sonbv00@gmail.com>
  • Loading branch information
sonbui00 authored and terrytangyuan committed Sep 5, 2023
1 parent 80a0cd5 commit b0909c6
Show file tree
Hide file tree
Showing 2 changed files with 25 additions and 4 deletions.
27 changes: 24 additions & 3 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ E2E_PARALLEL ?= 20
E2E_SUITE_TIMEOUT ?= 15m

VERSION := latest
DOCKER_PUSH := false
DOCKER_PUSH ?= false

# VERSION is the version to be used for files in manifests and should always be latest unless we are releasing
# we assume HEAD means you are on a tag
Expand Down Expand Up @@ -442,12 +442,33 @@ endif

.PHONY: argosay
argosay:
cd test/e2e/images/argosay/v2 && docker build . -t argoproj/argosay:v2
ifeq ($(DOCKER_PUSH),true)
cd test/e2e/images/argosay/v2 && \
docker buildx build \
--platform linux/amd64,linux/arm64 \
-t argoproj/argosay:v2 \
--push \
.
else
cd test/e2e/images/argosay/v2 && \
docker build . -t argoproj/argosay:v2
endif
ifeq ($(K3D),true)
k3d image import -c $(K3D_CLUSTER_NAME) argoproj/argosay:v2
endif

.PHONY: argosayv1
argosayv1:
ifeq ($(DOCKER_PUSH),true)
docker push argoproj/argosay:v2
cd test/e2e/images/argosay/v1 && \
docker buildx build \
--platform linux/amd64,linux/arm64 \
-t argoproj/argosay:v1 \
--push \
.
else
cd test/e2e/images/argosay/v1 && \
docker build . -t argoproj/argosay:v1
endif

dist/argosay:
Expand Down
2 changes: 1 addition & 1 deletion test/e2e/images/argosay/v1/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM ubuntu:trusty-20190515
FROM ubuntu:mantic-20230807.1

RUN apt-get update && \
apt-get install -y apt-utils ca-certificates apt-transport-https cowsay --no-install-recommends && \
Expand Down

0 comments on commit b0909c6

Please sign in to comment.