fix: improve error message when the controller is set `templateRefere…

…ncing: Secure` (#8277) Signed-off-by: mikutas <23391543+mikutas@users.noreply.github.com>
argoproj · Mar 30, 2022 · b198b33 · b198b33
1 parent 5598b8c
commit b198b33
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/workflow/controller/operator.go b/workflow/controller/operator.go
@@ -3535,7 +3535,7 @@ func (woc *wfOperationCtx) setStoredWfSpec() error {
 			return err
 		}
 		if mergedWf.Spec.String() != woc.wf.Status.StoredWorkflowSpec.String() {
-			return fmt.Errorf("workflowTemplateRef reference may not change during execution when the controller is in reference mode")
+			return fmt.Errorf("WorkflowSpec may not change during execution when the controller is set `templateReferencing: Secure`")
 		}
 	}
 	return nil

diff --git a/workflow/controller/operator_test.go b/workflow/controller/operator_test.go
@@ -4733,7 +4733,7 @@ func TestValidReferenceMode(t *testing.T) {
 	woc = newWorkflowOperationCtx(woc.wf, controller)
 	woc.operate(ctx)
 	assert.Equal(t, wfv1.WorkflowError, woc.wf.Status.Phase)
-	assert.Equal(t, "workflowTemplateRef reference may not change during execution when the controller is in reference mode", woc.wf.Status.Message)
+	assert.Equal(t, "WorkflowSpec may not change during execution when the controller is set `templateReferencing: Secure`", woc.wf.Status.Message)
 
 	controller.Config.WorkflowRestrictions.TemplateReferencing = config.TemplateReferencingStrict
 	woc = newWorkflowOperationCtx(wf, controller)