Skip to content

Commit

Permalink
fix(controller): Drop Checking daemoned children without nodeID (Fixes
Browse files Browse the repository at this point in the history
…#10960) (#10974)

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
  • Loading branch information
jsoref authored and terrytangyuan committed Aug 11, 2023
1 parent d42b857 commit b694dcc
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion workflow/controller/exec_control.go
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,9 @@ func (woc *wfOperationCtx) handleExecutionControlError(nodeID string, wfNodesLoc

// killDaemonedChildren kill any daemoned pods of a steps or DAG template node.
func (woc *wfOperationCtx) killDaemonedChildren(nodeID string) {
woc.log.Infof("Checking daemoned children of %s", nodeID)
if nodeID != "" {
woc.log.Debugf("Checking daemoned children of %s", nodeID)
}
for _, childNode := range woc.wf.Status.Nodes {
if childNode.BoundaryID != nodeID {
continue
Expand Down

0 comments on commit b694dcc

Please sign in to comment.