feat: remove size limit of 128kb for workflow templates. Fixes #8789 (#…

…8796)

* feat: remove size limit of 128kb for workflow templates

Signed-off-by: Dillen Padhiar <dpadhiar99@gmail.com>

* test: removed unnecessary test case for large workflows

Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>

test/e2e/functional_test.go

@@ -339,29 +339,6 @@ func (s *FunctionalSuite) TestEventOnWorkflowSuccess() {
 		)
 }
 
-func (s *FunctionalSuite) TestLargeWorkflowFailure() {
-	var uid types.UID
-	s.Given().
-		Workflow("@expectedfailures/large-workflow.yaml").
-		When().
-		SubmitWorkflow().
-		WaitForWorkflow(120*time.Second).
-		Then().
-		ExpectWorkflow(func(t *testing.T, metadata *metav1.ObjectMeta, status *wfv1.WorkflowStatus) {
-			uid = metadata.UID
-		}).
-		ExpectAuditEvents(
-			fixtures.HasInvolvedObject(workflow.WorkflowKind, uid),
-			2,
-			func(t *testing.T, e []apiv1.Event) {
-				assert.Equal(t, "WorkflowRunning", e[0].Reason)
-
-				assert.Equal(t, "WorkflowFailed", e[1].Reason)
-				assert.Contains(t, e[1].Message, "workflow templates are limited to 128KB, this workflow is 128001 bytes")
-			},
-		)
-}
-
 func (s *FunctionalSuite) TestEventOnPVCFail() {
 	//  Test whether an WorkflowFailed event (with appropriate message) is emitted in case of error in creating the PVC
 	var uid types.UID

workflow/controller/workflowpod.go

@@ -266,11 +266,6 @@ func (woc *wfOperationCtx) createWorkflowPod(ctx context.Context, nodeName strin
 	}
 
 	envVarTemplateValue := wfv1.MustMarshallJSON(tmpl)
-	templateSize := len(envVarTemplateValue)
-	if templateSize > 128000 {
-		err = fmt.Errorf("workflow templates are limited to 128KB, this workflow is %d bytes", templateSize)
-		return nil, err
-	}
 
 	// Add standard environment variables, making pod spec larger
 	envVars := []apiv1.EnvVar{