feat: added support for http as an option for artifact upload. Fixes #…

…785 (#8405) Signed-off-by: Rohan Kumar <rohankmr414@gmail.com>
argoproj · Apr 18, 2022 · d22be82 · d22be82
1 parent 4471b59
commit d22be82
Show file tree

Hide file tree

Showing 33 changed files with 5,848 additions and 854 deletions.
diff --git a/api/jsonschema/schema.json b/api/jsonschema/schema.json
@@ -5765,7 +5765,7 @@
       "type": "object"
     },
     "io.argoproj.workflow.v1alpha1.HTTPArtifact": {
-      "description": "HTTPArtifact allows an file served on HTTP to be placed as an input artifact in a container",
+      "description": "HTTPArtifact allows a file served on HTTP to be placed as an input artifact in a container",
       "properties": {
         "headers": {
           "description": "Headers are an optional list of headers to send with HTTP requests for artifacts",
@@ -5774,9 +5774,17 @@
           },
           "type": "array"
         },
+        "passwordSecret": {
+          "$ref": "#/definitions/io.k8s.api.core.v1.SecretKeySelector",
+          "description": "PasswordSecret is the secret selector to the repository password"
+        },
         "url": {
           "description": "URL of the artifact",
           "type": "string"
+        },
+        "usernameSecret": {
+          "$ref": "#/definitions/io.k8s.api.core.v1.SecretKeySelector",
+          "description": "UsernameSecret is the secret selector to the repository username"
         }
       },
       "required": [

diff --git a/api/openapi-spec/swagger.json b/api/openapi-spec/swagger.json
@@ -10111,7 +10111,7 @@
       }
     },
     "io.argoproj.workflow.v1alpha1.HTTPArtifact": {
-      "description": "HTTPArtifact allows an file served on HTTP to be placed as an input artifact in a container",
+      "description": "HTTPArtifact allows a file served on HTTP to be placed as an input artifact in a container",
       "type": "object",
       "required": [
         "url"
@@ -10124,9 +10124,17 @@
             "$ref": "#/definitions/io.argoproj.workflow.v1alpha1.Header"
           }
         },
+        "passwordSecret": {
+          "description": "PasswordSecret is the secret selector to the repository password",
+          "$ref": "#/definitions/io.k8s.api.core.v1.SecretKeySelector"
+        },
         "url": {
           "description": "URL of the artifact",
           "type": "string"
+        },
+        "usernameSecret": {
+          "description": "UsernameSecret is the secret selector to the repository username",
+          "$ref": "#/definitions/io.k8s.api.core.v1.SecretKeySelector"
         }
       }
     },

diff --git a/docs/fields.md b/docs/fields.md
@@ -3231,7 +3231,7 @@ HDFSArtifact is the location of an HDFS artifact
 
 ## HTTPArtifact
 
-HTTPArtifact allows an file served on HTTP to be placed as an input artifact in a container
+HTTPArtifact allows a file served on HTTP to be placed as an input artifact in a container
 
 <details>
 <summary>Examples with this field (click to open)</summary>
@@ -3270,7 +3270,9 @@ HTTPArtifact allows an file served on HTTP to be placed as an input artifact in
 | Field Name | Field Type | Description   |
 |:----------:|:----------:|---------------|
 |`headers`|`Array<`[`Header`](#header)`>`|Headers are an optional list of headers to send with HTTP requests for artifacts|
+|`passwordSecret`|[`SecretKeySelector`](#secretkeyselector)|PasswordSecret is the secret selector to the repository password|
 |`url`|`string`|URL of the artifact|
+|`usernameSecret`|[`SecretKeySelector`](#secretkeyselector)|UsernameSecret is the secret selector to the repository username|
 
 ## OSSArtifact
 

diff --git a/manifests/base/crds/full/argoproj.io_clusterworkflowtemplates.yaml b/manifests/base/crds/full/argoproj.io_clusterworkflowtemplates.yaml
diff --git a/manifests/base/crds/full/argoproj.io_cronworkflows.yaml b/manifests/base/crds/full/argoproj.io_cronworkflows.yaml
diff --git a/manifests/base/crds/full/argoproj.io_workfloweventbindings.yaml b/manifests/base/crds/full/argoproj.io_workfloweventbindings.yaml
@@ -231,8 +231,30 @@ spec:
                                     - value
                                     type: object
                                   type: array
+                                passwordSecret:
+                                  properties:
+                                    key:
+                                      type: string
+                                    name:
+                                      type: string
+                                    optional:
+                                      type: boolean
+                                  required:
+                                  - key
+                                  type: object
                                 url:
                                   type: string
+                                usernameSecret:
+                                  properties:
+                                    key:
+                                      type: string
+                                    name:
+                                      type: string
+                                    optional:
+                                      type: boolean
+                                  required:
+                                  - key
+                                  type: object
                               required:
                               - url
                               type: object