fix: retry S3 on RequestError. Fixes #9914 (#12191)

Signed-off-by: Helge Willum Thingvad <1019305+tachylatus@users.noreply.github.com>
argoproj · May 5, 2024 · e8e9c2a · e8e9c2a
1 parent 18685ad
commit e8e9c2a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/workflow/artifacts/s3/errors.go b/workflow/artifacts/s3/errors.go
@@ -10,7 +10,7 @@ import (
 // s3TransientErrorCodes is a list of S3 error codes that are transient (retryable)
 // Reference: https://github.com/minio/minio-go/blob/92fe50d14294782d96402deb861d442992038109/retry.go#L90-L102
 var s3TransientErrorCodes = []string{
-	"InternalError",
+	"RequestError",
 	"RequestTimeout",
 	"Throttling",
 	"ThrottlingException",

diff --git a/workflow/artifacts/s3/errors_test.go b/workflow/artifacts/s3/errors_test.go
@@ -19,4 +19,7 @@ func TestIsTransientOSSErr(t *testing.T) {
 
 	nonOSSErr := errors.New("UnseenError")
 	assert.False(t, isTransientS3Err(nonOSSErr))
+
+	requestErr := minio.ErrorResponse{Code: "RequestError"}
+	assert.True(t, isTransientS3Err(requestErr))
 }