Skip to content

Commit

Permalink
fix(executor): GODEBUG=x509ignoreCN=0 (#5562)
Browse files Browse the repository at this point in the history
Signed-off-by: Alex Collins <alex_collins@intuit.com>
  • Loading branch information
alexec authored and simster7 committed Apr 1, 2021
1 parent bda3af2 commit f057894
Showing 1 changed file with 17 additions and 8 deletions.
25 changes: 17 additions & 8 deletions workflow/controller/workflowpod.go
Original file line number Diff line number Diff line change
Expand Up @@ -477,16 +477,25 @@ func containerIsPrivileged(ctr *apiv1.Container) bool {
}

func (woc *wfOperationCtx) createEnvVars() []apiv1.EnvVar {
var execEnvVars []apiv1.EnvVar
execEnvVars = append(execEnvVars, apiv1.EnvVar{
Name: common.EnvVarPodName,
ValueFrom: &apiv1.EnvVarSource{
FieldRef: &apiv1.ObjectFieldSelector{
APIVersion: "v1",
FieldPath: "metadata.name",
execEnvVars := []apiv1.EnvVar{
{
Name: common.EnvVarPodName,
ValueFrom: &apiv1.EnvVarSource{
FieldRef: &apiv1.ObjectFieldSelector{
APIVersion: "v1",
FieldPath: "metadata.name",
},
},
},
})
{
// This flag was introduced in Go 15 and will be removed in Go 16.
// x509: cannot validate certificate for ... because it doesn't contain any IP SANs
// https://github.com/argoproj/argo-workflows/issues/5563 - Upgrade to Go 16
// https://github.com/golang/go/issues/39568
Name: "GODEBUG",
Value: "x509ignoreCN=0",
},
}
if woc.controller.Config.Executor != nil {
execEnvVars = append(execEnvVars, woc.controller.Config.Executor.Env...)
}
Expand Down

0 comments on commit f057894

Please sign in to comment.