fix: Only cleanup agent pod if exists. Fixes #12659 (#13294)

- merge conflicts with tests removed in backport by agilgur5

Signed-off-by: oninowang <oninowang@tencent.com>
Signed-off-by: jswxstw <jswxstw@gmail.com>
Co-authored-by: jswxstw <jswxstw@gmail.com>
Co-authored-by: agilgur5 <agilgur5@gmail.com>
(cherry picked from commit 825aacf)

workflow/controller/controller_test.go

@@ -1114,7 +1114,6 @@ spec:
 
 	woc.operate(ctx)
 	assert.True(t, controller.processNextPodCleanupItem(ctx))
-	assert.True(t, controller.processNextPodCleanupItem(ctx))
 	assert.Equal(t, wfv1.WorkflowSucceeded, woc.wf.Status.Phase)
 	podCleanupKey := "test/my-wf/labelPodCompleted"
 	assert.Equal(t, 0, controller.podCleanupQueue.NumRequeues(podCleanupKey))
@@ -1147,7 +1146,6 @@ spec:
 	assert.True(t, controller.processNextPodCleanupItem(ctx))
 	assert.True(t, controller.processNextPodCleanupItem(ctx))
 	assert.True(t, controller.processNextPodCleanupItem(ctx))
-	assert.True(t, controller.processNextPodCleanupItem(ctx))
 	assert.Equal(t, wfv1.WorkflowFailed, woc.wf.Status.Phase)
 	pods, err := listPods(woc)
 	assert.NoError(t, err)
@@ -1188,6 +1186,5 @@ func TestWorkflowReferItselfFromExpression(t *testing.T) {
 
 	woc.operate(ctx)
 	assert.True(t, controller.processNextPodCleanupItem(ctx))
-	assert.True(t, controller.processNextPodCleanupItem(ctx))
 	assert.Equal(t, wfv1.WorkflowSucceeded, woc.wf.Status.Phase)
 }

workflow/controller/operator.go

@@ -2395,7 +2395,9 @@ func (woc *wfOperationCtx) markWorkflowPhase(ctx context.Context, phase wfv1.Wor
 			}
 		}
 		woc.updated = true
-		woc.controller.queuePodForCleanup(woc.wf.Namespace, woc.getAgentPodName(), deletePod)
+		if woc.hasTaskSetNodes() {
+			woc.controller.queuePodForCleanup(woc.wf.Namespace, woc.getAgentPodName(), deletePod)
+		}
 	}
 }