Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry (rerun) successful workflows from certain steps #11020

Closed
or-shachar opened this issue May 1, 2023 · 0 comments · Fixed by #11409
Closed

Retry (rerun) successful workflows from certain steps #11020

or-shachar opened this issue May 1, 2023 · 0 comments · Fixed by #11409
Labels
area/retry-manual Manual workflow "Retry" Action (API/CLI/UI). See retryStrategy for template-level retries type/feature Feature request

Comments

@or-shachar
Copy link
Contributor

or-shachar commented May 1, 2023

Summary

  • On feat: Allow step restart on workflow retry. Closes #2334 #2431 we added the option to rerun successful steps in the Retry operation.
  • This Allowed the user to select which steps to reset as part of the Retry command.
  • I think we can use the restartSuccesful property that was added to allow rerunning successful workflow from given steps.

Use Cases

  • I created a mechanism for rerun with debug pause (in short: all templates have the env variable ARGO_DEBUG_PAUSE_{{workflow.parameters.pause}}, the default value for pause is NEVER, when I use the Retry I override the value to AFTER).
  • I want to be able to use it also for successful workflows (for instance: I need to do manual operation on terraform state, I need to test out something manually etc etc).

Implementation

The Retry operation will fail if workflow is not in Failed or Error state:

case wfv1.WorkflowFailed, wfv1.WorkflowError:

IIUC, it should be fairly simple to change this condition to allow other states, in case the restartSuccesful and node selector were given.

WDYT?

cc: @markterm


Message from the maintainers:

Love this enhancement proposal? Give it a 👍. We prioritise the proposals with the most 👍.

@or-shachar or-shachar added the type/feature Feature request label May 1, 2023
terrytangyuan pushed a commit that referenced this issue Jul 27, 2023
…Fixes #11020 (#11409)

Signed-off-by: or-shachar <or.shachar@wiz.io>
@agilgur5 agilgur5 added the area/retry-manual Manual workflow "Retry" Action (API/CLI/UI). See retryStrategy for template-level retries label Sep 3, 2023
@agilgur5 agilgur5 changed the title feat: Retry (rerun) successful workflows from certain steps Retry (rerun) successful workflows from certain steps Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/retry-manual Manual workflow "Retry" Action (API/CLI/UI). See retryStrategy for template-level retries type/feature Feature request
Projects
None yet
2 participants