UI shows "null is not an object" if retry a failed container set workflow

[nice-pink]

Pre-requisites

• I have double-checked my configuration
• I can confirm the issues exists when I tested with :latest
• I'd like to contribute the fix myself (see contributing guide)

What happened/what you expected to happen?

If i retry a failed container set workflow from the UI (retry button upper left hand side in workflow view) the UI shows following error:

null is not an object (evaluating 'r.type')

Stack Trace
@https://argo-workflows.radiosphere.com/main.4552298cb2e9cc74bb4b.js:341:68304
@https://argo-workflows.radiosphere.com/main.4552298cb2e9cc74bb4b.js:341:67160
@https://argo-workflows.radiosphere.com/main.4552298cb2e9cc74bb4b.js:341:64859
Pa@https://argo-workflows.radiosphere.com/main.4552298cb2e9cc74bb4b.js:397:69883
uc@https://argo-workflows.radiosphere.com/main.4552298cb2e9cc74bb4b.js:397:96720
sc@https://argo-workflows.radiosphere.com/main.4552298cb2e9cc74bb4b.js:397:96645
$s@https://argo-workflows.radiosphere.com/main.4552298cb2e9cc74bb4b.js:397:93675
$s@[native code]
@https://argo-workflows.radiosphere.com/main.4552298cb2e9cc74bb4b.js:397:45316
@https://argo-workflows.radiosphere.com/main.4552298cb2e9cc74bb4b.js:405:3845
Xo@https://argo-workflows.radiosphere.com/main.4552298cb2e9cc74bb4b.js:397:45262
Uo@https://argo-workflows.radiosphere.com/main.4552298cb2e9cc74bb4b.js:397:45197
Ks@https://argo-workflows.radiosphere.com/main.4552298cb2e9cc74bb4b.js:397:90460
ba@https://argo-workflows.radiosphere.com/main.4552298cb2e9cc74bb4b.js:397:62277
ba@[native code]
@https://argo-workflows.radiosphere.com/main.4552298cb2e9cc74bb4b.js:432:1138209
@https://argo-workflows.radiosphere.com/main.4552298cb2e9cc74bb4b.js:341:212417
@https://argo-workflows.radiosphere.com/main.4552298cb2e9cc74bb4b.js:18:29137
@https://argo-workflows.radiosphere.com/main.4552298cb2e9cc74bb4b.js:18:28290
@https://argo-workflows.radiosphere.com/main.4552298cb2e9cc74bb4b.js:18:27358
@https://argo-workflows.radiosphere.com/main.4552298cb2e9cc74bb4b.js:18:27030
@https://argo-workflows.radiosphere.com/main.4552298cb2e9cc74bb4b.js:23:28558
@https://argo-workflows.radiosphere.com/main.4552298cb2e9cc74bb4b.js:18:27030

Component Stack

    in t
    in t
    in div
    in div
    in div
    in div
    in div
    in Unknown
    in Unknown
    in t
    in t
    in Unknown
    in t
    in t
    in t
    in div
    in Unknown
    in t
    in t
    in Unknown
    in t

Page needs to be reloaded to show Workflow list again.

Version

v3.4.7

Paste a small workflow that reproduces the issue. We must be able to run the workflow; don't enter a workflows that uses private images.

---
apiVersion: argoproj.io/v1alpha1
kind: WorkflowTemplate
metadata:
  name: container-set-test
  namespace: argo
spec:
  entrypoint: main
  arguments:
    parameters:
    - name: app
      value: app
  serviceAccountName: workflow
  templates:
  - name: main
    inputs:
      parameters:
      - name: app
    containerSet:
      containers:

      - name: run
        image: alpine:latest
        command: ["/bin/sh", "-c"]
        args:
        - |
          set -eux
          exit 0
        
      - name: fail
        image: alpine:latest
        command: ["/bin/sh", "-c"]
        args:
        - |
          set -eux
          exit 1

Logs from the workflow controller

kubectl logs -n argo deploy/workflow-controller | grep ${workflow}

Logs from in your workflow's wait container

kubectl logs -n argo -c wait -l workflows.argoproj.io/workflow=${workflow},workflow.argoproj.io/phase!=Succeeded

[terrytangyuan]

Does this only happen for containerSet workflows?

[nice-pink]

Yes, the retry works fine with other workflows.

[terrytangyuan]

Does the CLI argo retry work on containerSet workflows?

[nice-pink]

This issue only refers to the UI. The retry is started when pressing the retry button in the UI. But this error screen appears.

[terrytangyuan]

I am not able to reproduce it on latest so this might have been fixed. Can you try latest?

[nice-pink]

It's the same error with the images:

• quay.io/argoproj/workflow-controller:latest
• quay.io/argoproj/argocli:latest

Maybe it is Safari specific?! Safari version is Version 16.3 (16614.4.6.11.6, 16614)

null is not an object (evaluating 'r.type')
 Reload this page to try again.

Stack Trace
@https://argo-workflows.radiosphere.com/main.a768cf0bbc183c363c31.js:341:70569
@https://argo-workflows.radiosphere.com/main.a768cf0bbc183c363c31.js:341:69425
@https://argo-workflows.radiosphere.com/main.a768cf0bbc183c363c31.js:341:67124
Pa@https://argo-workflows.radiosphere.com/main.a768cf0bbc183c363c31.js:397:69883
uc@https://argo-workflows.radiosphere.com/main.a768cf0bbc183c363c31.js:397:96720
sc@https://argo-workflows.radiosphere.com/main.a768cf0bbc183c363c31.js:397:96645
$s@https://argo-workflows.radiosphere.com/main.a768cf0bbc183c363c31.js:397:93675
$s@[native code]
@https://argo-workflows.radiosphere.com/main.a768cf0bbc183c363c31.js:397:45316
@https://argo-workflows.radiosphere.com/main.a768cf0bbc183c363c31.js:405:3845
Xo@https://argo-workflows.radiosphere.com/main.a768cf0bbc183c363c31.js:397:45262
Uo@https://argo-workflows.radiosphere.com/main.a768cf0bbc183c363c31.js:397:45197
Ks@https://argo-workflows.radiosphere.com/main.a768cf0bbc183c363c31.js:397:90460
ba@https://argo-workflows.radiosphere.com/main.a768cf0bbc183c363c31.js:397:62277
ba@[native code]
@https://argo-workflows.radiosphere.com/main.a768cf0bbc183c363c31.js:432:1140915
@https://argo-workflows.radiosphere.com/main.a768cf0bbc183c363c31.js:341:214682
@https://argo-workflows.radiosphere.com/main.a768cf0bbc183c363c31.js:18:29137
@https://argo-workflows.radiosphere.com/main.a768cf0bbc183c363c31.js:18:28290
@https://argo-workflows.radiosphere.com/main.a768cf0bbc183c363c31.js:18:27358
@https://argo-workflows.radiosphere.com/main.a768cf0bbc183c363c31.js:18:27030
@https://argo-workflows.radiosphere.com/main.a768cf0bbc183c363c31.js:23:28558
@https://argo-workflows.radiosphere.com/main.a768cf0bbc183c363c31.js:18:27030
Component Stack

    in t
    in t
    in div
    in div
    in div
    in div
    in div
    in Unknown
    in Unknown
    in t
    in t
    in Unknown
    in t
    in t
    in t
    in div
    in Unknown
    in t
    in t
    in Unknown
    in Unknown

[terrytangyuan]

Perhaps try another browser? Unfortunately the stacktrace isn't very informative.

[nice-pink]

The issue appears also in Chrome, but the text differs a bit:

Chrome version Version 112.0.5615.137

Cannot read properties of null (reading 'type')
 Reload this page to try again.

Stack Trace
TypeError: Cannot read properties of null (reading 'type')
    at t.getOutboundNodes (https://argo-workflows.radiosphere.com/main.4552298cb2e9cc74bb4b.js:341:68305)
    at t.prepareGraph (https://argo-workflows.radiosphere.com/main.4552298cb2e9cc74bb4b.js:341:67144)
    at t.render (https://argo-workflows.radiosphere.com/main.4552298cb2e9cc74bb4b.js:341:64847)
    at Pa (https://argo-workflows.radiosphere.com/main.4552298cb2e9cc74bb4b.js:397:69877)
    at Da (https://argo-workflows.radiosphere.com/main.4552298cb2e9cc74bb4b.js:397:69672)
    at ms (https://argo-workflows.radiosphere.com/main.4552298cb2e9cc74bb4b.js:397:105471)
    at uc (https://argo-workflows.radiosphere.com/main.4552298cb2e9cc74bb4b.js:397:96718)
    at sc (https://argo-workflows.radiosphere.com/main.4552298cb2e9cc74bb4b.js:397:96643)
    at $s (https://argo-workflows.radiosphere.com/main.4552298cb2e9cc74bb4b.js:397:93673)
    at https://argo-workflows.radiosphere.com/main.4552298cb2e9cc74bb4b.js:397:45315
Component Stack

    in t
    in t
    in div
    in div
    in div
    in div
    in div
    in Unknown
    in Unknown
    in t
    in t
    in Unknown
    in t
    in t
    in t
    in div
    in Unknown
    in t
    in t
    in Unknown
    in t

[terrytangyuan]

That is more informative. I am working on a potential fix. When the builds become green https://github.com/argoproj/argo-workflows/actions/runs/4938495540/jobs/8828346726, can you try the image tag dev-containerset-ui?

[nice-pink]

I'll check tomorrow.

[nice-pink]

Safari and Chrome don't show the error message anymore. So everything is fine there, I guess.

But a different problem occurs: When the containerSet workflow is finished (and failed) the workflow is not shown in the list of workflows anymore if I reload the list of workflows. Reload either by Ctrl-R or pressing the Workflows icon in the upper right hand corner. When I switching back to v3.4.7 version the workflows are shown in the list of workflows.

[terrytangyuan]

Can you check your browser developer console to see if there are any error messages?

[terrytangyuan]

Sent #11071 to fix the original issue. I cannot reproduce the second issue with list of workflows that you mentioned.