Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check All checkbox on Workflow DAG filter dropdown #11129

Closed
jmeridth opened this issue May 25, 2023 · 0 comments · Fixed by #11132
Closed

Check All checkbox on Workflow DAG filter dropdown #11129

jmeridth opened this issue May 25, 2023 · 0 comments · Fixed by #11132
Assignees
@jmeridth
Labels
area/ui type/feature Feature request

Comments

@jmeridth
Copy link
Member

Summary

A new Select All checkbox on Workflow DAG filter dropdown

All unchecked, Select All unchecked:

Screenshot 2023-05-25 at 12 59 37 PM

All checked, Select All is checked:

Screenshot 2023-05-25 at 12 59 44 PM

One unchecked, Select All is unchecked:

Screenshot 2023-05-25 at 12 59 50 PM

Use Cases

To quickly uncheck or check all filter checkboxes. Currently you have to do it one by one manually.

Message from the maintainers:

Love this enhancement proposal? Give it a 👍. We prioritise the proposals with the most 👍.
@jmeridth jmeridth added the type/feature Feature request label May 25, 2023
@jmeridth jmeridth self-assigned this May 25, 2023
jmeridth added a commit to jmeridth/argo-workflows that referenced this issue May 25, 2023
@jmeridth @stevenbjohnson
feat: Add Select All checkbox to workflow dag filter options
e273819 
Fixes argoproj#11129

- [x] also fixed bug when click some labels of checkboxes, they would change state of other same-named checkboxes. This was due to non-unique IDs on the checkboxes.

Signed-off-by: jmeridth <jmeridth@gmail.com>
Signed-off-by: Ben Compton <3343482+bencompton@users.noreply.github.com>
Co-Authored-by: Steven Johnson <steven.johnson@procore.com>
jmeridth added a commit to jmeridth/argo-workflows that referenced this issue May 25, 2023
@jmeridth @bencompton @stevenbjohnson
feat: Add Select All checkbox to workflow dag filter options
f0d0b4a 
Fixes argoproj#11129

- [x] also fixed bug when click some labels of checkboxes, they would change state of other same-named checkboxes. This was due to non-unique IDs on the checkboxes.

Signed-off-by: jmeridth <jmeridth@gmail.com>
Co-Authored-by: Ben Compton <3343482+bencompton@users.noreply.github.com>
Co-Authored-by: Steven Johnson <steven.johnson@procore.com>
@jmeridth jmeridth mentioned this issue May 25, 2023
Merged
4 tasks
jmeridth added a commit to jmeridth/argo-workflows that referenced this issue May 25, 2023
@jmeridth @stevenbjohnson
feat: Add Select All checkbox to workflow dag filter options
3265851 
Fixes argoproj#11129

- [x] also fixed bug when click some labels of checkboxes, they would change state of other same-named checkboxes. This was due to non-unique IDs on the checkboxes.

Signed-off-by: Ben Compton <3343482+bencompton@users.noreply.github.com>
Co-Authored-by: jmeridth <jmeridth@gmail.com>
Co-Authored-by: Steven Johnson <steven.johnson@procore.com>
jmeridth added a commit to jmeridth/argo-workflows that referenced this issue May 25, 2023
@jmeridth @bencompton @stevenbjohnson
feat: Add Select All checkbox to workflow dag filter options
3ab761b 
Fixes argoproj#11129

- [x] also fixed bug when click some labels of checkboxes, they would change state of other same-named checkboxes. This was due to non-unique IDs on the checkboxes.

Signed-off-by: jmeridth <jmeridth@gmail.com>
Co-Authored-by: Ben Compton <3343482+bencompton@users.noreply.github.com>
Co-Authored-by: Steven Johnson <steven.johnson@procore.com>
jmeridth added a commit to jmeridth/argo-workflows that referenced this issue May 25, 2023
@jmeridth @bencompton @stevenbjohnson
feat: Add Select All checkbox to workflow dag filter options
c115462 
Fixes argoproj#11129

- [x] also fixed bug when click some labels of checkboxes, they would change state of other same-named checkboxes. This was due to non-unique IDs on the checkboxes.

Signed-off-by: jmeridth <jmeridth@gmail.com>
Co-Authored-by: Ben Compton <3343482+bencompton@users.noreply.github.com>
Co-Authored-by: Steven Johnson <steven.johnson@procore.com>
jmeridth added a commit to jmeridth/argo-workflows that referenced this issue May 25, 2023
@jmeridth @bencompton @stevenbjohnson
feat: Add Select All checkbox to workflow dag filter options
cdb9b49 
Fixes argoproj#11129

- [x] also fixed bug when click some labels of checkboxes, they would change state of other same-named checkboxes. This was due to non-unique IDs on the checkboxes.

Signed-off-by: jmeridth <jmeridth@gmail.com>
Co-Authored-by: Ben Compton <3343482+bencompton@users.noreply.github.com>
Co-Authored-by: Steven Johnson <steven.johnson@procore.com>
@jmeridth jmeridth changed the title Select All checkbox on Workflow DAG filter dropdown Check All checkbox on Workflow DAG filter dropdown May 26, 2023
terrytangyuan pushed a commit that referenced this issue Jun 1, 2023
@jmeridth
feat: Add Check All checkbox to workflow dag filter options. Fixes #…
3273709 
…11129 (#11132)
JPZ13 pushed a commit to pipekit/argo-workflows that referenced this issue Jul 4, 2023
@jmeridth @JPZ13
feat: Add Check All checkbox to workflow dag filter options. Fixes a…
3f24c4f 
…rgoproj#11129 (argoproj#11132)
jeremyhager pushed a commit to jeremyhager/argo-workflows that referenced this issue Jul 7, 2023
@jmeridth @jeremyhager
feat: Add Check All checkbox to workflow dag filter options. Fixes a…
cef8b25 
…rgoproj#11129 (argoproj#11132)

Signed-off-by: Jeremy Hager <47301461+jeremyhager@users.noreply.github.com>
@terrytangyuan terrytangyuan mentioned this issue Aug 2, 2023
Closed
@agilgur5 agilgur5 mentioned this issue Oct 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jmeridth jmeridth

Labels
area/ui type/feature Feature request
Projects
Argo Workflows UI/UX Improvements
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add Check All checkbox to workflow dag filter options. Fixes #11129 jmeridth/argo-workflows
2 participants
@jmeridth @agilgur5