[Pre-release] UI crashes when thare are archived workflows which has same name and namespace.

[toyamagu-2021]

Pre-requisites

• I have double-checked my configuration
• I can confirm the issues exists when I tested with :latest
• I'd like to contribute the fix myself (see contributing guide)

What happened/what you expected to happen?

Behaviour

• UI crashes when there are archived workflows that have the same name and namespace.

To reproduce

• Create two archived workflow which has the same name.
• Open a workflow detail page.
• 
• 

Cause

• [getWorkflow] pass to backend only ${name} and ${namespace} to backend

  • argo-workflows/ui/src/app/shared/services/workflows-service.ts

    Lines 69 to 70 in 22d4e17

    	getArchived(namespace: string, name: string) {
    	return requests.get(`api/v1/archived-workflows/?name=${name}&namespace=${namespace}`).then(res => res.body as models.Workflow);

• Backend returns error when there are one more than workflows in DB

  • argo-workflows/persist/sqldb/workflow_archive.go

    Line 279 in 22d4e17

    return nil, fmt.Errorf("found %d archived workflows with namespace/name: %s/%s", num, namespace, name)

To resolve

• I'm not sure, but we should pass uid to WorkflowDetails.ts by routing?

  • argo-workflows/ui/src/app/workflows/components/workflows-container.tsx

    Line 3 in 22d4e17

    import {WorkflowDetails} from './workflow-details/workflow-details';

Version

master

Paste a small workflow that reproduces the issue. We must be able to run the workflow; don't enter a workflows that uses private images.

N/A

Logs from the workflow controller

N/A

Logs from in your workflow's wait container

N/A

[terrytangyuan]

The existing workflow with the same name+namespace should be deleted before submitting another one. Perhaps when performing resubmit, we should delete the existing one first?

[toyamagu-2021]

I think this issue does not relate to resubmitting itself.
ArchivedWorkflow should be queried by uid from ui, right?
Currently, that is queried by only name and namespace.
Therefore, the error is raised when DB has multiple workflows which has the same name.

Before v3.4.8, the above situations work well because archived workflow is queried by following.

    get(uid: string, namespace: string) {
        if (namespace === '') {
            return requests.get(`api/v1/archived-workflows/${uid}`).then(res => res.body as models.Workflow);
        } else {
            return requests.get(`api/v1/archived-workflows/${uid}?namespace=${namespace}`).then(res => res.body as models.Workflow);
        }
    },

(Forgive me if I terribly taken something wrong)

[terrytangyuan]

Support for get archived workflow by name+namespace is added in #11055. The assumption of using that is users would avoid submitting duplicate workflows. Perhap in the UI, we can stick with querying archived workflow by UID. Would you like to give that a try?

[JPZ13]

@terrytangyuan and @toyamagu-2021 - given #11055 and UID querying, should we close this issue?

[terrytangyuan]

This will be fixed in #11373