-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
parent level memoization is broken #11612
Comments
@terrytangyuan Yes, it seems my last commit makes this problem. I think I found the reason why, but have to refine the way to solve this. Please assign me. And will this be a hotfix? Do I just PR to master or to release branch directly? Maybe I need some reviews. |
PR to master branch would be fine. We can send PR to release branch later once we are planning it. |
@Paritosh-Anand just for sure, is this what you are experiencing now? for the first run of your example. it is okay. but for the second run, it is like below. (node appear and infinite pending) ...which is originally should be like this (because of caching) |
Signed-off-by: shmruin <meme_hm@naver.com>
@shmruin thanks for looking into this. yes that is correct. |
…oproj#11623) Signed-off-by: shmruin <meme_hm@naver.com>
…oproj#11623) (argoproj#11660) Signed-off-by: shmruin <meme_hm@naver.com> Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>
Pre-requisites
:latest
What happened/what you expected to happen?
What happened
Upgrading to v3.4.10 impaired an existing functionality of parent level memoization.
Scenario:
We have few workflows with memoization enabled on the parent level of a
dag
orsteps
and each step or task inside don't have memoization enabled.Expectation:
If parent level memoization results in cache hit, then the child tasks shouldn't get evaluated or processed.
Impact
Post upgrading from v3.4.8 to v3.4.10 we observed that
task
orstep
got stuck in Pending state.Due ever spinning nodes in the workflow it delayed the overall CI feedback and developers being blocked. Hence, resulting in poor developer experience.
Version
v3.4.10
Paste a small workflow that reproduces the issue. We must be able to run the workflow; don't enter a workflows that uses private images.
Logs from the workflow controller
Logs from in your workflow's wait container
The text was updated successfully, but these errors were encountered: