Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect message on UI when podGC is enabled with deleteDelayDuration #12395

Closed
bkanuka opened this issue Dec 21, 2023 · 2 comments · Fixed by #12784
Closed

Incorrect message on UI when podGC is enabled with deleteDelayDuration #12395

bkanuka opened this issue Dec 21, 2023 · 2 comments · Fixed by #12784
Assignees
@shuangkun
Labels
area/gc Garbage collection, such as TTLs, retentionPolicy, delays, and more area/ui P2 Important. All bugs with >=3 thumbs up that aren’t P0 or P1, plus: Any other bugs deemed important solution/suggested A solution to the bug has been suggested. Someone needs to implement it. type/bug
Milestone
v3.5.x patches

Comments

@bkanuka
Copy link

bkanuka commented Dec 21, 2023 •
edited by agilgur5
Loading

Summary

I have my workflowDefaults set with:

      podGC:
        strategy: OnWorkflowCompletion
        deleteDelayDuration: 168h  # Delete pods 7 days after completion

However, the UI states: "Your pod GC settings will delete pods and their logs immediately on completion. ". This isn't quite true because my pods will be deleted 7 days after completion.

I would propose that this message is not shown when the podGC is set to anything other than the default, or greater than the default.

Use Cases

I use OnWorkflowCompletion and a long deleteDelayDuration so that my Kubernetes cluster isn't forever holding on to a growing list of completed pods. Keeping only the last week of pods is sufficient and keeps the list of pods in k8s at a reasonable level.

Message from the maintainers:

Love this enhancement proposal? Give it a 👍. We prioritise the proposals with the most 👍.
@bkanuka bkanuka added the type/feature Feature request label Dec 21, 2023
@agilgur5 agilgur5 added type/bug area/ui P2 Important. All bugs with >=3 thumbs up that aren’t P0 or P1, plus: Any other bugs deemed important and removed type/feature Feature request labels Dec 21, 2023
@agilgur5
Copy link

Ah yea, Workflow-level deleteDelayDuration is a newer feature I added in #11325 that released in 3.5, so that message pre-dates the existence of the feature.

Would you like to contribute a fix for the message when deleteDelayDuration is used?

@bkanuka
Copy link
Author

bkanuka commented Dec 23, 2023 via email

@agilgur5 agilgur5 added the solution/suggested A solution to the bug has been suggested. Someone needs to implement it. label Dec 27, 2023
@agilgur5 agilgur5 added the area/gc Garbage collection, such as TTLs, retentionPolicy, delays, and more label Feb 18, 2024
@shuangkun shuangkun self-assigned this Mar 6, 2024
shuangkun added a commit to shuangkun/argo-workflows that referenced this issue Mar 12, 2024
@shuangkun
fix: Incorrect message on UI when podGC is enabled with deleteDelayDu…
d799994 
…ration. Fixes: argoproj#12395

Signed-off-by: shuangkun <tsk2013uestc@163.com>
@shuangkun shuangkun mentioned this issue Mar 12, 2024
Merged
agilgur5 added a commit that referenced this issue Mar 12, 2024
@shuangkun
fix(ui): show correct podGC message for deleteDelayDuration. Fixes: #…
20ece9c 
…12395 (#12784)

Signed-off-by: shuangkun <tsk2013uestc@163.com>
Signed-off-by: shuangkun tian <72060326+shuangkun@users.noreply.github.com>
Signed-off-by: Anton Gilgur <4970083+agilgur5@users.noreply.github.com>
Co-authored-by: Anton Gilgur <4970083+agilgur5@users.noreply.github.com>
agilgur5 added a commit to agilgur5/argo-workflows that referenced this issue Mar 12, 2024
@shuangkun @agilgur5
fix(ui): show correct podGC message for deleteDelayDuration. Fixes: a…
03f9f75 
…rgoproj#12395 (argoproj#12784)

Signed-off-by: shuangkun <tsk2013uestc@163.com>
Signed-off-by: shuangkun tian <72060326+shuangkun@users.noreply.github.com>
Signed-off-by: Anton Gilgur <4970083+agilgur5@users.noreply.github.com>
Co-authored-by: Anton Gilgur <4970083+agilgur5@users.noreply.github.com>
@agilgur5 agilgur5 added this to the v3.5.x patches milestone Apr 3, 2024
isubasinghe pushed a commit to isubasinghe/argo-workflows that referenced this issue May 6, 2024
@shuangkun @agilgur5 @isubasinghe
fix(ui): show correct podGC message for deleteDelayDuration. Fixes: a…
61867de 
…rgoproj#12395 (argoproj#12784)

Signed-off-by: shuangkun <tsk2013uestc@163.com>
Signed-off-by: shuangkun tian <72060326+shuangkun@users.noreply.github.com>
Signed-off-by: Anton Gilgur <4970083+agilgur5@users.noreply.github.com>
Co-authored-by: Anton Gilgur <4970083+agilgur5@users.noreply.github.com>
isubasinghe pushed a commit to isubasinghe/argo-workflows that referenced this issue May 7, 2024
@shuangkun @agilgur5 @isubasinghe
fix(ui): show correct podGC message for deleteDelayDuration. Fixes: a…
1a259cb 
…rgoproj#12395 (argoproj#12784)

Signed-off-by: shuangkun <tsk2013uestc@163.com>
Signed-off-by: shuangkun tian <72060326+shuangkun@users.noreply.github.com>
Signed-off-by: Anton Gilgur <4970083+agilgur5@users.noreply.github.com>
Co-authored-by: Anton Gilgur <4970083+agilgur5@users.noreply.github.com>
agilgur5 added a commit that referenced this issue Jul 6, 2024
revert: "fix(ui): show correct podGC message for deleteDelayDuration. F…
1f600ff 
…ixes: #12395 (#12784)"

This reverts commit 1a259cb, which was erroneously backported to `release-3.4` when it is a fix for a 3.5 feature

Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
@argoproj argoproj locked as resolved and limited conversation to collaborators Sep 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@shuangkun shuangkun

Labels
area/gc Garbage collection, such as TTLs, retentionPolicy, delays, and more area/ui P2 Important. All bugs with >=3 thumbs up that aren’t P0 or P1, plus: Any other bugs deemed important solution/suggested A solution to the bug has been suggested. Someone needs to implement it. type/bug
Projects
None yet
Milestone
v3.5.x patches
Development

Successfully merging a pull request may close this issue.

fix(ui): show correct podGC message for deleteDelayDuration. Fixes: #12395 shuangkun/argo-workflows
3 participants
@bkanuka @agilgur5 @shuangkun