-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v3.4.14 Broken redirect to archived workflows #13056
Comments
We're still experiencing the same issue on 3.4.17. Navigating to Navigating directly to the archived workflow on |
@diegofd This has not been fixed yet |
@apiwoni I know, sorry if my wording told a different thing :) |
We're encountering this issue too (or similar): Navigating to This page doesn't work for most of us (but seems to for admins). For me it shows a permission denied error since it's trying to list all workflows for the empty namespace. Manually changing the link to this works: I wonder if this wasn't caught since it's not affecting admins. |
any idea @terrytangyuan ? |
The
Possibly. That and that 3.4 isn't used during dev at all. Tests won't run on PRs to branches either. |
I see the diff now, the first slash needed to be removed when |
Fixed in #13712 and should be released in the next 3.4 patch, 3.4.18 |
Pre-requisites
:latest
image tag (i.e.quay.io/argoproj/workflow-controller:latest
) and can confirm the issue still exists on:latest
. If not, I have explained why, in detail, in my description below.What happened/what did you expect to happen?
The following URL
https://{{serverUrl}}/workflows/{namespace}/{workflowName}
no longer redirects tohttps://{{serverUrl}}/archived-workflows/{namespace}/{metadata.uid}
starting with v3.4.14 when fix(ui): missing uiUrl in ArchivedWorkflowsList #12172 has been committed.Pasting
https://{{serverUrl}}/archived-workflows/{namespace}/{metadata.uid}
directly in the browser works as expected.Argo UI shows the following:
componentDidUpdate has added uiUrl in v3.4.14 per https://github.com/argoproj/argo-workflows/pull/12172/files
Version
v3.4.16
Paste a small workflow that reproduces the issue. We must be able to run the workflow; don't enter a workflows that uses private images.
N/A
Logs from the workflow controller
Logs from in your workflow's wait container
The text was updated successfully, but these errors were encountered: