Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to run Controller locally on Arm mac M1 #13112

Closed
4 tasks done
Adrien-D opened this issue May 29, 2024 · 1 comment · Fixed by #13113
Closed
4 tasks done

Unable to run Controller locally on Arm mac M1 #13112

Adrien-D opened this issue May 29, 2024 · 1 comment · Fixed by #13113
Labels
area/build Build or GithubAction/CI issues area/contributing Contributing docs, ownership, etc. Also devtools like devcontainer and Nix type/bug

Comments

@Adrien-D
Copy link
Member

Adrien-D commented May 29, 2024 •
edited
Loading

Pre-requisites

  • I have double-checked my configuration
  • I have tested with the :latest image tag (i.e. quay.io/argoproj/workflow-controller:latest) and can confirm the issue still exists on :latest. If not, I have explained why, in detail, in my description below.
  • I have searched existing issues and could not find a match for this bug
  • I'd like to contribute the fix myself (see contributing guide)

What happened/what did you expect to happen?

When running make start UI=true on devcontainer with vscode extension I get this error

image

Running those commands I get

image

Looking at this line TARGET_PLATFORM := $(shell [ `uname -m` = arm64 ] && echo linux/arm64 || echo linux/amd64) it must be using linux/amd64 as target platform which is wrong

Version

v3.5.7
@Adrien-D Adrien-D mentioned this issue May 29, 2024
Merged
@agilgur5 agilgur5 added area/build Build or GithubAction/CI issues area/contributing Contributing docs, ownership, etc. Also devtools like devcontainer and Nix labels May 29, 2024
@agilgur5
Copy link
Contributor

Running those commands I get

Please use text instead of images -- text is much more accessible.

Typing it out:

$ uname -s
Linux
$ uname -m
aarch64

@agilgur5 agilgur5 changed the title Unable to run the Workflow Controller locally on my Arm mac M1 Unable to run Controller locally on my Arm mac M1 May 29, 2024
@agilgur5 agilgur5 changed the title Unable to run Controller locally on my Arm mac M1 Unable to run Controller locally on Arm mac M1 May 29, 2024
agilgur5 added a commit that referenced this issue Jun 5, 2024
@Adrien-D @agilgur5
fix(build): uname handling for mac M1 arch. Fixes #13112 (#13113)
58dbcd0 
Co-authored-by: Anton Gilgur <agilgur5@gmail.com>
Signed-off-by: Adrien Delannoy <a.delannoyfr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/build Build or GithubAction/CI issues area/contributing Contributing docs, ownership, etc. Also devtools like devcontainer and Nix type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(build): uname handling for mac M1 arch. Fixes #13112 Adrien-D/argo-workflows
2 participants
@Adrien-D @agilgur5