UI: Ability to change parameters when re-submitting workflows

[amoldharamshi]

Summary

Need ability to change parameters/arguments while resubmitting workflows in Argo UI

Use Case

In case of failures or if we want to run the workflow again with different parameters/arguments, we need ability to do so using Argo UI

[alexec]

Thank you @amoldharamshi I'll speak to my colleagues about your request.

[alexec]

Might be good to fix #3453 at the same time. I'm imagining a new panel that pops up similar to submitting from workflow templates. That would be neat.

[simster7]

Might be good to fix #3453 at the same time. I'm imagining a new panel that pops up similar to submitting from workflow templates. That would be neat.

Sure thing, I'll take care of this as well

[simster7]

I added the ability to set parameters in the workflow submit pane. It's a little trickier to add this in the workflow resubmit pane. I will bring this up with the team tomorrow

[simster7]

Done

[alexec]

Re-opening so we can do this.

[Guillermogsjc]

Hi @alexec @simster7 ,

it would be really useful to allow to the argo client function resubmit to admit the --parameter flag as does submit.

Something like

argo resubmit -n argo -p UPDATED_PARAMETER=updated_value EXISTING_WORKFLOW_NAME

The use case is pretty clear, you want to retry a workflow changing some parameters.

[alexec]

This issue is about UI. Please raise new issue.

[kennytrytek-wf]

I'd like to take this one, please. My understanding is that the resubmit UI should have an option in addition to the OK and Cancel buttons to update parameter values before submission. I'm not sure of the best solution for all cases.

For workflow templates and cluster workflow templates, I think it would be good to redirect to the template submission view with the inputs pre-filled on the selected entrypoint, since that would help give a consistent experience submitting workflow templates from the UI.

The difficulty comes for non-template workflows. It seems like we would need a new submit panel that did essentially the same thing as the template submission, but for a workflow that doesn't have a defined template. I don't want to duplicate all the same submit logic in a new place; would it be possible to use the same workflow submission form for both workflow templates and free-form workflows?

[kennytrytek-wf]

Looking through the code a bit more, this actually seems like it's largely already solved in this case:
https://github.com/argoproj/argo-workflows/blob/master/ui/src/app/workflows/components/workflow-creator.tsx

I'd like to propose the following behavior when clicking the Resubmit button:

• For a [cluster] workflow template, the SubmitWorkflowPanel side panel is shown, populated with the entrypoint and parameter values that were used in the workflow. Submission will issue a submit request.
• For a non-templated workflow, the WorkflowEditor side panel is shown, populated with any information available in the executed workflow. Submission will issue a create request.

[terrytangyuan]

@toyamagu-2021 Can you comment here so that I can assign this to you?

[toyamagu-2021]

@terrytangyuan
Thank you for your mention!