Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default annotations for workflow pods #4985

Closed
dylanhellems opened this issue Feb 1, 2021 · 3 comments · Fixed by #5031
Closed

Default annotations for workflow pods #4985

dylanhellems opened this issue Feb 1, 2021 · 3 comments · Fixed by #5031
Labels
type/feature Feature request

Comments

@dylanhellems
Copy link
Contributor

Summary

It would be useful to have the ability to set default annotations for all pods in a workflow via the default workflow spec. Perhaps pods in a workflow could inherit the annotations on the workflow itself? Or another configuration option could be added for this purpose.

Use Cases

We use kube2iam for AWS access which includes our s3 artifact repository. Unless I'm missing something, it seems like every template needs to have an annotation individually applied to it so that it can archive logs. I'd like to be able to apply a default annotation to all workflow pods via the default workflow spec, which would save every workflow definitions from needing to know about that role.


Message from the maintainers:

Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.

@dylanhellems dylanhellems added the type/feature Feature request label Feb 1, 2021
@alexec
Copy link
Contributor

alexec commented Feb 1, 2021

would you like to submit a PR to add this feature?

@dylanhellems
Copy link
Contributor Author

I can look into it when I have time; it's really more of a nice to have than a necessity.

@dylanhellems
Copy link
Contributor Author

PR up: #5031

alexec pushed a commit that referenced this issue Feb 10, 2021
 (#5031)

Signed-off-by: Dylan Hellems <dylanhellems@gmail.com>
@simster7 simster7 mentioned this issue Feb 16, 2021
33 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature Feature request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants