Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Argo event generate workflow name using epoch time cause duplicate name. #6732

Closed
zoftdev opened this issue Sep 14, 2021 · 0 comments · Fixed by #6995
Closed

Argo event generate workflow name using epoch time cause duplicate name. #6732

zoftdev opened this issue Sep 14, 2021 · 0 comments · Fixed by #6995
Labels

Comments

@zoftdev
Copy link

zoftdev commented Sep 14, 2021

Create multiple workflow in same time via /api/v1/events/ cause problem.
Because argo try to generate name by itself using epoch time.

               nameSuffix := fmt.Sprintf("%v", time.Now().Unix())

		if wf.Name == "" {
			// make sure we have a predicable name, so re-creation doesn't create two workflows
			wf.SetName(wf.GetGenerateName() + nameSuffix)
		}
 

Testing :
create wf , wfbinding and request curl

curl -i -k --location --request POST 'https://localhost:2746/api/v1/events/namespace/wfbinding'
--header 'Content-Type: application/json'
--data-raw '{
"message": "toon"
}

Diagnostics

👀 Yes! We need all of your diagnostics, please make sure you add it all, otherwise we'll go around in circles asking you for it:

What Kubernetes provider are you using?
1.22

What version of Argo Workflows are you running?
3.1.0

What executor are you running? Docker/K8SAPI/Kubelet/PNS/Emissary
K8SAPI
Did this work in a previous version? I.e. is it a regression?
No
Are you pasting thousands of log lines? That's too much information.

@sarabala1979 sarabala1979 modified the milestone: v3.2 Sep 15, 2021
@alexec alexec added solution/workaround There's a workaround, might not be great, but exists invalid labels Sep 21, 2021
@stale stale bot removed the wontfix label Sep 21, 2021
@alexec alexec added wontfix and removed solution/workaround There's a workaround, might not be great, but exists invalid labels Sep 21, 2021
alexec added a commit to alexec/argo-workflows that referenced this issue Oct 20, 2021
…roj#6981 and argoproj#6732

Signed-off-by: Alex Collins <alex_collins@intuit.com>
alexec added a commit to alexec/argo-workflows that referenced this issue Oct 20, 2021
alexec added a commit to alexec/argo-workflows that referenced this issue Oct 20, 2021
@alexec alexec changed the title Agro event generate workflow name using epoch time cause duplicate name. Argo event generate workflow name using epoch time cause duplicate name. Oct 20, 2021
alexec added a commit that referenced this issue Oct 22, 2021
…and #6732 (#6995)

Signed-off-by: Alex Collins <alex_collins@intuit.com>
kriti-sc pushed a commit to kriti-sc/argo-workflows that referenced this issue Oct 24, 2021
…roj#6981 and argoproj#6732 (argoproj#6995)

Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: kriti-sc <kathuriakriti1@gmail.com>
alexec added a commit that referenced this issue Oct 24, 2021
…and #6732 (#6995)

Signed-off-by: Alex Collins <alex_collins@intuit.com>
@sarabala1979 sarabala1979 mentioned this issue Oct 26, 2021
25 tasks
@sarabala1979 sarabala1979 mentioned this issue Nov 4, 2021
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants