Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better containerRuntimeExecutor default #6785

Closed
pedro-mandeville opened this issue Sep 22, 2021 · 3 comments · Fixed by #6882
Closed

Better containerRuntimeExecutor default #6785

pedro-mandeville opened this issue Sep 22, 2021 · 3 comments · Fixed by #6882
Labels

Comments

@pedro-mandeville
Copy link

Summary

Change the default executor to one that works out of the box on more k8s distribution

It seems docker is not a good default as it does not work on every k8s distribution, for example, GKE and microk8s.
Thus a lot of new users trying Argo-Workflow have trouble figuring out why the hello-word example does not work (the wait container get stuck).
As en example, I joined the argo slack channel yesterday and in less than 24 hours there were 3 questions regarding this exactly same issue.

The documentation also does not tells that Argo-Workflow may not work out of the box depending on your k8s distribution. Neither how you can fix it.


Message from the maintainers:

Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.

@pedro-mandeville pedro-mandeville added the type/feature Feature request label Sep 22, 2021
@alexec
Copy link
Contributor

alexec commented Sep 22, 2021

I agree with this, more generally deprecating the Docker executor, and defaulting to either the PNS or Emissary executor. The latter is designed to be faster and more powerful, but is new (introduced in v3.1), so not proven yet. I think we could make it the default in v3.3.

Would you be interested in making the code changes?

@pedro-mandeville
Copy link
Author

I'm not sure were to make the changes but if there is no one else available, with some guide I can prepare a PR

@terrytangyuan
Copy link
Member

+1 to PNS or emissary. Though if we want to make emissary the default, we may need to check all the examples to see if the commands are explicitly specified.

alexec pushed a commit that referenced this issue Oct 18, 2021
Signed-off-by: Tianchu Zhao <evantczhao@gmail.com>
@sarabala1979 sarabala1979 mentioned this issue Oct 21, 2021
24 tasks
kriti-sc pushed a commit to kriti-sc/argo-workflows that referenced this issue Oct 24, 2021
…goproj#6882)

Signed-off-by: Tianchu Zhao <evantczhao@gmail.com>
Signed-off-by: kriti-sc <kathuriakriti1@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants