Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[plugin] add more workflow data in executor plugin #8573

Closed
whybeyoung opened this issue May 2, 2022 · 0 comments · Fixed by #9784
Closed

[plugin] add more workflow data in executor plugin #8573

whybeyoung opened this issue May 2, 2022 · 0 comments · Fixed by #9784
Labels
area/plugins type/feature Feature request

Comments

@whybeyoung
Copy link
Contributor

whybeyoung commented May 2, 2022 •
edited
Loading

Summary

executor api only have the workflow name data and it is not enough in many usecases. so we should add more workflow meta data in executor.

Use Cases

writing argo volocano plugin, and when we setup the volcanojob, we want to set it's ownnerreference in the plugin code, we need workflow id, and namespace.

Message from the maintainers:

Love this enhancement proposal? Give it a 👍. We prioritise the proposals with the most 👍.
@whybeyoung whybeyoung added the type/feature Feature request label May 2, 2022
This was referenced May 2, 2022
Closed
Closed
@alexec alexec mentioned this issue Oct 10, 2022
Closed
8 tasks
alexec added a commit to alexec/argo-workflows that referenced this issue Oct 10, 2022
@alexec
fix: Send workflow UID to plugins. Fixes argoproj#8573
47d98ee 
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec alexec mentioned this issue Oct 10, 2022
Merged
8 tasks
alexec added a commit that referenced this issue Oct 10, 2022
@alexec
fix: Send workflow UID to plugins. Fixes #8573 (#9784)
cd43bba 
Signed-off-by: Alex Collins <alex_collins@intuit.com>
juchaosong pushed a commit to juchaosong/argo-workflows that referenced this issue Nov 3, 2022
@alexec @juchaosong
fix: Send workflow UID to plugins. Fixes argoproj#8573 (argoproj#9784)
d9e3e02 
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: juchao <juchao@coscene.io>
@sarabala1979 sarabala1979 mentioned this issue Nov 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/plugins type/feature Feature request
Projects
None yet
Milestone
No milestone
2 participants
@alexec @whybeyoung