Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backoff under retryStrategy does not work as expected for version 3.3.8 #9170

Closed
Ali-RT opened this issue Jul 18, 2022 · 7 comments · Fixed by #9213
Closed

backoff under retryStrategy does not work as expected for version 3.3.8 #9170

Ali-RT opened this issue Jul 18, 2022 · 7 comments · Fixed by #9213
Assignees
Labels
area/retryStrategy Template-level retryStrategy type/bug type/regression Regression from previous behavior (a specific type of bug)

Comments

@Ali-RT
Copy link

Ali-RT commented Jul 18, 2022

The backoff feature for retryStrategy does not behave as expected under version 3.3.8.

      retryStrategy:
        limit: "10"
        backoff:
          duration: "30m"   

The workflow was retried 10 times, but the wait time between each retry call was about 21 seconds.

Tested under version 3.2.4, and it worked as expected.

@sarabala1979
Copy link
Member

@dpadhiar Can you try to reproduce this issue?

@dpadhiar
Copy link
Member

@sarabala1979 Yes.

@dpadhiar
Copy link
Member

@sarabala1979 Confirmed backoff duration isn't working on 3.3.8.

@raafatseif
Copy link

Hi @sarabala1979 @dpadhiar ! Do you think this can be fixed in a new release soon? It's the only thing preventing us from deploying to production so far.

@dpadhiar
Copy link
Member

@raafatseif Yes, we will look into getting this fixed before 3.3.9/3.4 is released.

@sarabala1979 sarabala1979 added type/regression Regression from previous behavior (a specific type of bug) and removed triage labels Jul 20, 2022
@sarabala1979 sarabala1979 self-assigned this Jul 20, 2022
@HRusby
Copy link

HRusby commented Jul 21, 2022

To add to this, I've tested against v3.3.7 where the Backoff duration is working. This issue must have been introduced between v3.3.7 and v3.3.8.

Could we also add a required unit test for this to prevent regression in the future?

@raafatseif
Copy link

@HRusby I was able to reproduce the issue in v3.3.7

sarabala1979 pushed a commit that referenced this issue Aug 1, 2022
…ixes #9170. (#9213)

* fix: retryStrategy.Limit is now read properly

Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>

* test: add test case for backoff

Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>

* chore: empty commit

Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>

* test: update test case to check for certain amount of retries

Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>

* test: added second case where limit is a string

Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>
@sarabala1979 sarabala1979 mentioned this issue Aug 2, 2022
51 tasks
terrytangyuan pushed a commit that referenced this issue Aug 2, 2022
…ixes #9170. (#9213)

* fix: retryStrategy.Limit is now read properly

Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>

* test: add test case for backoff

Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>

* chore: empty commit

Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>

* test: update test case to check for certain amount of retries

Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>

* test: added second case where limit is a string

Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>
@alexec alexec added the area/retry-manual Manual workflow "Retry" Action (API/CLI/UI). See retryStrategy for template-level retries label Sep 6, 2022
juchaosong pushed a commit to juchaosong/argo-workflows that referenced this issue Nov 3, 2022
…ixes argoproj#9170. (argoproj#9213)

* fix: retryStrategy.Limit is now read properly

Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>

* test: add test case for backoff

Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>

* chore: empty commit

Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>

* test: update test case to check for certain amount of retries

Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>

* test: added second case where limit is a string

Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>
Signed-off-by: juchao <juchao@coscene.io>
reddymh pushed a commit to reddymh/argo-workflows that referenced this issue Jan 2, 2023
…ixes argoproj#9170. (argoproj#9213)

* fix: retryStrategy.Limit is now read properly

Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>

* test: add test case for backoff

Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>

* chore: empty commit

Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>

* test: update test case to check for certain amount of retries

Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>

* test: added second case where limit is a string

Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>
Signed-off-by: Reddy <Rajshekar.Reddy@lowes.com>
@agilgur5 agilgur5 added area/retryStrategy Template-level retryStrategy and removed area/retry-manual Manual workflow "Retry" Action (API/CLI/UI). See retryStrategy for template-level retries labels Apr 25, 2024
@argoproj argoproj locked as resolved and limited conversation to collaborators Apr 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/retryStrategy Template-level retryStrategy type/bug type/regression Regression from previous behavior (a specific type of bug)
Projects
None yet
7 participants