Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: differentiate between no currentNamespace and empty currentNamespace #9266

Closed
3 tasks done
LoricAndre opened this issue Aug 1, 2022 · 0 comments · Fixed by #9267
Closed
3 tasks done

Fix: differentiate between no currentNamespace and empty currentNamespace #9266

LoricAndre opened this issue Aug 1, 2022 · 0 comments · Fixed by #9267
Labels
area/ui type/bug

Comments

@LoricAndre
Copy link
Contributor

LoricAndre commented Aug 1, 2022 •
edited
Loading

Checklist

  • Double-checked my configuration.
  • Tested using the latest version.
  • Used the Emissary executor.

Summary

What happened/what you expected to happen?
After logging in with SSO on the server (using the UI) in the latest master, the namespace is always reset to the user's namespace when the current namespace is empty, but it should stay at cluster level. This is due to #9008

What version are you running?
Latest master

Diagnostics

Paste the smallest workflow that reproduces the bug. We must be able to run the workflow.

This is observed from the UI.

Message from the maintainers:

Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.
@LoricAndre LoricAndre mentioned this issue Aug 1, 2022
Merged
terrytangyuan pushed a commit that referenced this issue Aug 1, 2022
@LoricAndre
Fix: user namespace override (Fixes #9266) (#9267)
b565bf3 
fix: user namespace override

Signed-off-by: Loric ANDRE <loric.a@padoa-group.com>
@alexec alexec added the area/ui label Sep 6, 2022
juchaosong pushed a commit to juchaosong/argo-workflows that referenced this issue Nov 3, 2022
@LoricAndre @juchaosong
Fix: user namespace override (Fixes argoproj#9266) (argoproj#9267)
ce76099 
fix: user namespace override

Signed-off-by: Loric ANDRE <loric.a@padoa-group.com>
Signed-off-by: juchao <juchao@coscene.io>
reddymh pushed a commit to reddymh/argo-workflows that referenced this issue Jan 2, 2023
@LoricAndre
Fix: user namespace override (Fixes argoproj#9266) (argoproj#9267)
112fd7a 
fix: user namespace override

Signed-off-by: Loric ANDRE <loric.a@padoa-group.com>
Signed-off-by: Reddy <Rajshekar.Reddy@lowes.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/ui type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: user namespace override (Fixes #9266) padoa/argo-workflows
2 participants
@alexec @LoricAndre