Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3.4: clicking on input arifact in UI crashes UI #9391

Closed
alexec opened this issue Aug 18, 2022 · 1 comment · Fixed by #9392
Closed

v3.4: clicking on input arifact in UI crashes UI #9391

alexec opened this issue Aug 18, 2022 · 1 comment · Fixed by #9392

Comments

@alexec
Copy link
Contributor

alexec commented Aug 18, 2022

  1. Run the artifact-workflowtemplate.yaml.
  2. Click on the "annual.csv" input artifacts.
    3.See undefined is not an object (evaluating 'Y.find((function(e){return e.name===x.name})).artifactGC') error.

Clicking "Reload the page" fixes the issue.

I think it must be this:

artifactGCStrategy = artifacts.find(a => a.name === artifact.name).artifactGC?.strategy || spec.artifactGC?.strategy;

Change to

const artifactGCStrategy = artifacts?.find(a => a.name === artifact.name)?.artifactGC?.strategy || spec.artifactGC?.strategy;
terrytangyuan added a commit to terrytangyuan/argo-workflows that referenced this issue Aug 18, 2022
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
terrytangyuan added a commit to terrytangyuan/argo-workflows that referenced this issue Aug 18, 2022
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
@terrytangyuan
Copy link
Member

We had the same issue and went ahead and fixed (different from what you suggested) to make it to the next release candidate today. #9392

terrytangyuan added a commit that referenced this issue Aug 18, 2022
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
juchaosong pushed a commit to juchaosong/argo-workflows that referenced this issue Nov 3, 2022
… (argoproj#9392)

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
Signed-off-by: juchao <juchao@coscene.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants