fix (argo wait): use functions to constrain ctx instead of blocks

[sxllwx]

Signed-off-by: scott scottwangsxll@gmail.com

Fixes: as the title says

Please do not open a pull request until you have checked ALL of these:

• Create the PR as draft .
• Run make pre-commit -B to fix codegen and lint problems.
• Sign-off your commits (otherwise the DCO check will fail).
• Use a conventional commit message (otherwise the commit message check will fail).
• "Fixes #" is in both the PR title (for release notes) and this description (to automatically link and close the issue).
• Add unit or e2e tests. Say how you tested your changes. If you changed the UI, attach screenshots.
• Github checks are green.
• Once required tests have passed, mark your PR "Ready for review".

If changes were requested, and you've made them, dismiss the review to get it reviewed again.

[alexec]

What problem does this fix?

[sxllwx]

Please correct me if I understand wrong, thx.

     // use a function to constrain the scope of ctx
      {
		// this allows us to gracefully shutdown, capturing artifacts
		ctx, cancel := signal.NotifyContext(ctx, syscall.SIGTERM)
		defer cancel()

		// Wait for main container to complete
		err := wfExecutor.Wait(ctx)
		if err != nil {
			wfExecutor.AddError(err)
		}
	}

As mentioned in the comment, the block here is to limit the scope of ctx. expected execution result is to call cancel after the scope of ctx ends (that is, when the code segment of the block is executed). However, due to the use of the defer keyword, defer will only be executed after the end of the function, not after the end of the code segment in the block.

sample-code: https://go.dev/play/p/Bvwy9tswNm8

ps: The current code runs without any problems. This patch will make our code more grammatically correct. 😄

[alexec]

Better grammar is good!