Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: 'Enforcing history limit' log to Debug level #10474

Merged
merged 1 commit into from
Apr 19, 2023

Conversation

tooptoop4
Copy link
Contributor

Currently this is being logged every 10 seconds per different cron workflow. Can be costly to log aggregators if having many cronWorkflows

alexec
alexec previously requested changes Feb 12, 2023
Copy link
Contributor

@alexec alexec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign-off your commits.

auto-merge was automatically disabled February 13, 2023 15:12

Merge queue setting changed

@stale
Copy link

stale bot commented Mar 25, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this is a mentoring request, please provide an update here. Thank you for your contributions.

@stale stale bot added the problem/stale This has not had a response in some time label Mar 25, 2023
@tooptoop4
Copy link
Contributor Author

crispy, these logs costing $70 a day!

@stale stale bot removed the problem/stale This has not had a response in some time label Apr 13, 2023
Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix DCO check

@terrytangyuan terrytangyuan merged commit 82e5b0a into argoproj:master Apr 19, 2023
JPZ13 pushed a commit to pipekit/argo-workflows that referenced this pull request Jul 4, 2023
dpadhiar pushed a commit to dpadhiar/argo-workflows that referenced this pull request May 9, 2024
Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants