fix(agent): no more requeue when the node succeeded #10681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexec
reviewed
Mar 19, 2023
ok~ |
sxllwx
force-pushed
the
fix/never-requeue-when-node-succeeded
branch
from
0489744
to
b7325a3
Compare
|
done~ PTAL, thx @alexec |
Signed-off-by: scott <scottwangsxll@gmail.com>
sxllwx
force-pushed
the
fix/never-requeue-when-node-succeeded
branch
from
b7325a3
to
380d370
Compare
alexec
reviewed
Mar 27, 2023
| @@ -368,6 +368,9 @@ func (ae *AgentExecutor) executePluginTemplate(ctx context.Context, tmpl wfv1.Te | |||
| return 0, err | |||
| } else if reply.Node != nil { | |||
| *result = *reply.Node | |||
| if reply.Node.Phase == wfv1.NodeSucceeded { | |||
There was a problem hiding this comment.
Should this include failed and errored nodes?
There was a problem hiding this comment.
I don't think so. Because in failure, the user needs to explicitly give the delay of the requeue.
alexec
approved these changes
Apr 3, 2023
elifarley
pushed a commit
to elifarley/argo-workflows
that referenced
this pull request
Apr 6, 2023
Signed-off-by: scott <scottwangsxll@gmail.com> Signed-off-by: Elifarley <elifarley@gmail.com>
JPZ13
pushed a commit
to pipekit/argo-workflows
that referenced
this pull request
Jul 4, 2023
Signed-off-by: scott <scottwangsxll@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: As the title