-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Allow script and container image to be set in templateDefault. Fixes #9633 #10784
fix: Allow script and container image to be set in templateDefault. Fixes #9633 #10784
Conversation
5a2ca95
to
06ecf8f
Compare
06ecf8f
to
26dd7c5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also add a test for the functionality, e.g. e2e test?
@terrytangyuan sure no problem, do you have a particular suite or file you would like it added to? |
8d8dff6
to
9fde944
Compare
Head branch was pushed to by a user without write access
d977286
to
12e2715
Compare
…ixes argoproj#9633 Signed-off-by: Rory Doherty <rory@tigera.io>
12e2715
to
3feae8c
Compare
…ixes argoproj#9633 (argoproj#10784) Signed-off-by: Rory Doherty <rory@tigera.io>
…ixes argoproj#9633 (argoproj#10784) Signed-off-by: Rory Doherty <rory@tigera.io> Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>
Made changes to validation to check if the script/container Image has been set in templateDefaults
Testing
Added unit tests to verify these situations
Also created the following via the locally deployed UI and then submitted both via the UI and they were successful:
and a cron workflow
Fixes #9633