Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: tableName is empty if wfc.session != nil #10887

Merged
merged 2 commits into from
Apr 13, 2023
Merged

fix: tableName is empty if wfc.session != nil #10887

merged 2 commits into from
Apr 13, 2023

Conversation

mikutas
Copy link
Contributor

@mikutas mikutas commented Apr 12, 2023 •
edited
Loading

Once wfc.session is initialized, tableName come to empty.

So added sqldb.GetTableName and made sqldb.CreateDBSession not to return tableName.

Fixes #10888

@mikutas
fix: tableName is empty if wfc.session != nil
e648ae6 
Signed-off-by: mikutas <23391543+mikutas@users.noreply.github.com>
@terrytangyuan terrytangyuan marked this pull request as ready for review April 13, 2023 13:38
@terrytangyuan terrytangyuan enabled auto-merge (squash) April 13, 2023 13:38
@terrytangyuan
Copy link
Member

terrytangyuan commented Apr 13, 2023 •
edited
Loading

Thanks. Can you test it out and confirm it's working after the change?

@terrytangyuan terrytangyuan merged commit b904851 into argoproj:master Apr 13, 2023
@acobaugh acobaugh mentioned this pull request Apr 14, 2023
Closed
3 tasks
@mikutas mikutas deleted the fix-tablename-empty branch April 14, 2023 07:20
@terrytangyuan terrytangyuan mentioned this pull request May 22, 2023
Closed
44 tasks
terrytangyuan added a commit that referenced this pull request May 25, 2023
@mikutas @terrytangyuan
fix: tableName is empty if wfc.session != nil (#10887)
f98227c 
Signed-off-by: mikutas <23391543+mikutas@users.noreply.github.com>
Co-authored-by: Yuan Tang <terrytangyuan@gmail.com>
JPZ13 pushed a commit to pipekit/argo-workflows that referenced this pull request Jul 4, 2023
@mikutas @terrytangyuan @JPZ13
fix: tableName is empty if wfc.session != nil (argoproj#10887)
be70c0e 
Signed-off-by: mikutas <23391543+mikutas@users.noreply.github.com>
Co-authored-by: Yuan Tang <terrytangyuan@gmail.com>
@agilgur5 agilgur5 mentioned this pull request Apr 19, 2024
Closed
4 tasks
dpadhiar pushed a commit to dpadhiar/argo-workflows that referenced this pull request May 9, 2024
@mikutas @terrytangyuan @dpadhiar
fix: tableName is empty if wfc.session != nil (argoproj#10887)
cf87db5 
Signed-off-by: mikutas <23391543+mikutas@users.noreply.github.com>
Co-authored-by: Yuan Tang <terrytangyuan@gmail.com>
Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terrytangyuan terrytangyuan terrytangyuan approved these changes

Assignees
No one assigned
Labels
area/server
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failed to list old offloaded nodes" err="Error 1103 (42000): Incorrect table name ''
3 participants
@mikutas @terrytangyuan @agilgur5