Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Validate label values from workflowMetadata to avoid controller crash. Fixes #10872 #10892

Merged
merged 3 commits into from
Apr 14, 2023

Conversation

terrytangyuan
Copy link
Member

Fixes #10872

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
…crash. Fixes argoproj#10872

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
@terrytangyuan terrytangyuan enabled auto-merge (squash) April 13, 2023 13:28
@terrytangyuan terrytangyuan merged commit c8e7fa8 into argoproj:master Apr 14, 2023
@terrytangyuan terrytangyuan deleted the fix-crash-wf-metadata branch April 14, 2023 18:18
terrytangyuan added a commit that referenced this pull request May 25, 2023
…crash. Fixes #10872 (#10892)

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
JPZ13 pushed a commit to pipekit/argo-workflows that referenced this pull request Jul 4, 2023
…crash. Fixes argoproj#10872 (argoproj#10892)

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
dpadhiar pushed a commit to dpadhiar/argo-workflows that referenced this pull request May 9, 2024
…crash. Fixes argoproj#10872 (argoproj#10892)

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't Crash Controller when an Invalid Workflow Object is present
2 participants