fix: Replace expressions with placeholders in resource manifest template. Fixes #10924 #10926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ate. Fixes argoproj#10924 Signed-off-by: Alexander Crow <acrow@akamai.com>
Signed-off-by: Alexander Crow <acrow@akamai.com>
maxsxu
reviewed
Apr 24, 2023
There was a problem hiding this comment.
@crowcrow Thanks for this fix! I'm sure we've run into this problem many times.
Just give more details for reproduction: this issue only occurs when the WorkflowTemplate is submitted via the argo CLI or argo UI (to argo-server), not the kubectl (to kube-apiserver).
maxsxu
reviewed
Apr 24, 2023
| s.Given(). | ||
| WorkflowTemplate("@testdata/workflow-template-with-resource-expr.yaml"). | ||
| When(). | ||
| CreateWorkflowTemplates(). |
There was a problem hiding this comment.
It seems the CreateWorkflowTemplates is not a qualified test case as it submit WorkflowTemplate to kube-apiserver not argo-server, so it cannot cover this PR's scenario.
So it might be better to add this test case to the argo_server_test or cli_test unit?
alexec
approved these changes
Apr 24, 2023
terrytangyuan
approved these changes
Apr 24, 2023
44 tasks
JPZ13
pushed a commit
to pipekit/argo-workflows
that referenced
this pull request
Jul 4, 2023
…ate. Fixes argoproj#10924 (argoproj#10926) Signed-off-by: Alexander Crow <acrow@akamai.com>
dpadhiar
pushed a commit
to dpadhiar/argo-workflows
that referenced
this pull request
May 9, 2024
…ate. Fixes argoproj#10924 (argoproj#10926) Signed-off-by: Alexander Crow <acrow@akamai.com> Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10924