Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add lastRetry.message #10987

Merged
merged 2 commits into from
Apr 26, 2023
Merged

Conversation

Joibel
Copy link
Member

@Joibel Joibel commented Apr 26, 2023

As requested in #9937 add a message field to lastRetry to allow fine grained control of retries.

Tested with unit test and a manually with a simple workflow which conditionally retried on lastRetry.message=="some words"

Fixes #9937

As requested in argoproj#9937 add a message field to lastRetry to allow fine
grained control of retries.

Closes argoproj#9937

Signed-off-by: Alan Clucas <alan@clucas.org>
@Joibel Joibel marked this pull request as ready for review April 26, 2023 10:59
docs/retries.md Outdated Show resolved Hide resolved
docs/variables.md Outdated Show resolved Hide resolved
Signed-off-by: Alan Clucas <alan@clucas.org>
@terrytangyuan terrytangyuan merged commit c49d33b into argoproj:master Apr 26, 2023
@Joibel Joibel deleted the retryMessage branch May 28, 2023 18:25
JPZ13 pushed a commit to pipekit/argo-workflows that referenced this pull request Jul 4, 2023
Signed-off-by: Alan Clucas <alan@clucas.org>
@agilgur5 agilgur5 added area/templating Templating with `{{...}}` area/retry-manual Manual workflow "Retry" Action (API/CLI/UI). See retryStrategy for template-level retries area/retryStrategy Template-level retryStrategy and removed area/retry-manual Manual workflow "Retry" Action (API/CLI/UI). See retryStrategy for template-level retries labels Apr 24, 2024
@argoproj argoproj locked as resolved and limited conversation to collaborators Apr 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/retryStrategy Template-level retryStrategy area/templating Templating with `{{...}}`
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add message field to lastRetry for conditional retries
4 participants