Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update memoization.md #10992

Merged
merged 3 commits into from
May 10, 2023
Merged

docs: Update memoization.md #10992

merged 3 commits into from
May 10, 2023

Conversation

eriadam
Copy link
Contributor

@eriadam eriadam commented Apr 27, 2023

TODO: Say why you made your changes.

The first question I had was about the validity of the cached items. Turns out is is possible to set.

TODO: Say what changes you made.

Added the information about the maxAge parameter of the memoise step feature and a link to its example on Github.

TODO: Say how you tested your changes.

Preview.

Added the information about the maxAge parameter and a link to the example on Github.

Signed-off-by: Adam Eri <adam.eri@blackmirror.media>
@terrytangyuan terrytangyuan changed the title Update memoization.md docs: Update memoization.md Apr 27, 2023
docs/memoization.md Outdated Show resolved Hide resolved
Copy link
Contributor

@maxsxu maxsxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@maxsxu maxsxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eriadam It seems your latest commit didn't signed-off, which causes the CI/DCO failed.

@terrytangyuan terrytangyuan enabled auto-merge (squash) May 10, 2023 00:00
@terrytangyuan terrytangyuan merged commit 992773f into argoproj:master May 10, 2023
JPZ13 pushed a commit to pipekit/argo-workflows that referenced this pull request Jul 4, 2023
Signed-off-by: Adam Eri <adam.eri@blackmirror.media>
Co-authored-by: Yuan Tang <terrytangyuan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants