Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Update Bitbucket SSH host key #11091

Merged
merged 1 commit into from
May 16, 2023
Merged

fix: Update Bitbucket SSH host key #11091

merged 1 commit into from
May 16, 2023

Conversation

toredash
Copy link
Contributor

@toredash
fix: Update Bitbucket SSH host key
42ebe66 
Signed-off-by: Tore S. Loenoey <tore.lonoy@gmail.com>
@toredash
Copy link
Contributor Author

related;

Had an issue where cloning resulted in:

level=fatal msg="artifact bitbucket-repository failed to load: failed to clone \"git@bitbucket.org:X/X.git\": ssh: handshake failed: knownhosts: key mismatch"

This started to occur after bitbucket added their keys as of 15th of May (blogpost). This would not happen if go-git was upgraded to >=5.5.0, as it includes a fix described here (go-git/go-git#411)

I'm not sure why the go-git module is forked in argo-workflow (

argo-workflows/go.mod

Line 260 in c1c3a5a

replace github.com/go-git/go-git/v5 => github.com/argoproj-labs/go-git/v5 v5.4.7
), but argo-cd uses the upstream version of go-git (argoproj/argo-cd#11893). They have had similar problems (https://github.com/argoproj/argo-cd/issues/7723)[](url)

@terrytangyuan terrytangyuan enabled auto-merge (squash) May 16, 2023 17:37
@terrytangyuan
Copy link
Member

Thank you. For anyone else having the issue, the workaround is to mount the updated host keys in /etc/ssh/

@terrytangyuan terrytangyuan merged commit 019705e into argoproj:master May 16, 2023
@terrytangyuan
Copy link
Member

related;

Had an issue where cloning resulted in:

level=fatal msg="artifact bitbucket-repository failed to load: failed to clone \"git@bitbucket.org:X/X.git\": ssh: handshake failed: knownhosts: key mismatch"

This started to occur after bitbucket added their keys as of 15th of May (blogpost). This would not happen if go-git was upgraded to >=5.5.0, as it includes a fix described here (go-git/go-git#411)

I'm not sure why the go-git module is forked in argo-workflow (

argo-workflows/go.mod

Line 260 in c1c3a5a

replace github.com/go-git/go-git/v5 => github.com/argoproj-labs/go-git/v5 v5.4.7

), but argo-cd uses the upstream version of go-git (argoproj/argo-cd#11893). They have had similar problems ([https://github.com/argoproj/argo-cd/issues/7723)

Thanks. Let's track this in #10091

@terrytangyuan terrytangyuan mentioned this pull request May 16, 2023
Open
woehrl01 pushed a commit to woehrl01/argo-workflows that referenced this pull request May 17, 2023
@toredash @woehrl01
fix: Update Bitbucket SSH host key (argoproj#11091)
78f655e 
Signed-off-by: Tore S. Loenoey <tore.lonoy@gmail.com>
Co-authored-by: Tore S. Loenoey <torestendal.lonoy@tv2.no>
@terrytangyuan terrytangyuan mentioned this pull request May 22, 2023
Closed
44 tasks
terrytangyuan pushed a commit that referenced this pull request May 25, 2023
@toredash @terrytangyuan
fix: Update Bitbucket SSH host key (#11091)
55dc31d 
Signed-off-by: Tore S. Loenoey <tore.lonoy@gmail.com>
Co-authored-by: Tore S. Loenoey <torestendal.lonoy@tv2.no>
JPZ13 pushed a commit to pipekit/argo-workflows that referenced this pull request Jul 4, 2023
@toredash @JPZ13
fix: Update Bitbucket SSH host key (argoproj#11091)
25c236b 
Signed-off-by: Tore S. Loenoey <tore.lonoy@gmail.com>
Co-authored-by: Tore S. Loenoey <torestendal.lonoy@tv2.no>
@agilgur5 agilgur5 added solution/workaround There's a workaround, might not be great, but exists area/artifacts S3/GCP/OSS/Git/HDFS etc labels Sep 26, 2023
dpadhiar pushed a commit to dpadhiar/argo-workflows that referenced this pull request May 9, 2024
@toredash @dpadhiar
fix: Update Bitbucket SSH host key (argoproj#11091)
c276276 
Signed-off-by: Tore S. Loenoey <tore.lonoy@gmail.com>
Co-authored-by: Tore S. Loenoey <torestendal.lonoy@tv2.no>
Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terrytangyuan terrytangyuan terrytangyuan approved these changes

Assignees
No one assigned
Labels
area/artifacts S3/GCP/OSS/Git/HDFS etc solution/workaround There's a workaround, might not be great, but exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@toredash @terrytangyuan @agilgur5