fix: Fixed path separator in .tgz output artifacts created on windows. Fixes #10562 #11097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Kögel <peter.koegel@vector.com>
PeterKoegel
changed the title
There was a problem hiding this comment.
@lippertmarkus Would you mind helping us review this change?
lippertmarkus
approved these changes
May 19, 2023
|
@terrytangyuan names in tar headers need to use forward slashes for the tar archive to extract correctly on both Linux and Windows, so the fix is fine |
44 tasks
JPZ13
pushed a commit
to pipekit/argo-workflows
that referenced
this pull request
Jul 4, 2023
…Fixes argoproj#10562 (argoproj#11097) Signed-off-by: Peter Kögel <peter.koegel@vector.com>
dpadhiar
pushed a commit
to dpadhiar/argo-workflows
that referenced
this pull request
May 9, 2024
…Fixes argoproj#10562 (argoproj#11097) Signed-off-by: Peter Kögel <peter.koegel@vector.com> Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>
agilgur5
added
area/artifacts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10562
Motivation
Output artifacts in .tgz format that are created on Windows result in wrong directory and file structure when unpacked by 7-zip or on Linux.
Example:
Folder structure Windows is
A\B\C.txtAn output artifact in .tgz format is generated from this (on Windows)
The resulting .tgz archive is opened in 7zip
Modifications
When generating the tar archive the pathes that are written to the tar-file's file header are converted to use forward slashes instead of backslashes independent of the current operation systems path format.
Verification
When the above example is repeaded after this fix then 7zip shows the correct folder structure: