fix: Make devcontainer able to pre-commit #11153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make pre-commit doesn't work in devcontainer, with this commit it does. This fixes that by a) Moving GOPATH to /home/vscode/go b) Installing protoc (apt package protobuf-compiler) c) Ensuring ~/go is writable (so subdirs can be created) d) Ensuring /home/vscode/go/bin is on the path too Using /home/vscode/go rather than /go is necessary when doing all the protocol malarky due to requirements on subdirectories. Signed-off-by: Alan Clucas <alan@clucas.org>
terrytangyuan
approved these changes
May 30, 2023
JPZ13
pushed a commit
to pipekit/argo-workflows
that referenced
this pull request
Jul 4, 2023
Signed-off-by: Alan Clucas <alan@clucas.org>
61 tasks
terrytangyuan
pushed a commit
that referenced
this pull request
Jul 19, 2023
Signed-off-by: Alan Clucas <alan@clucas.org>
6 tasks
6 tasks
dpadhiar
pushed a commit
to dpadhiar/argo-workflows
that referenced
this pull request
May 9, 2024
Signed-off-by: Alan Clucas <alan@clucas.org> Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>
agilgur5
added
the
area/contributing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make pre-commit doesn't work in devcontainer, with this commit it does.
Motivation
I'd like an easy way for everyone to be able to maintain workflows, and devcontainers are nearly there.
Modifications
This fixes that by
a) Moving GOPATH to /home/vscode/go
b) Installing protoc (apt package protobuf-compiler)
c) Ensuring ~/go is writable (so subdirs can be created)
d) Ensuring /home/vscode/go/bin is on the path too
Using /home/vscode/go rather than /go is necessary when doing all the protocol malarky due to requirements on subdirectories.
Verification
Launched a new devcontainer with these changes, and ensure
make pre-commitreaches the end successfully. The resulting tree is unchanged, so all the generated code matches that in git.