feat: Allow memoization without outputs #11379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please note: I am not totally in favour of this change, it makes memoization work without outputs and I'm not conviced this is actually healthy, but it's what people seem to expect. See the linked issues in the fixes list below. This change will cause memoization to work for all step and dag tasks even without outputs. Note: They were working semi-erroneously for some dag tasks due to implicit outputs before this change. Fixes argoproj#11280 (raised to cover this desire) Fixes argoproj#10769 (already closed by documentation) Partially addresses argoproj#10426: Dags will memoize now, but retries still won't Signed-off-by: Alan Clucas <alan@clucas.org>
terrytangyuan
approved these changes
Jul 25, 2023
|
A bit hesitant but there seems to be more good than harm |
Agreed, but thanks for merging. |
3 tasks
6 tasks
This was referenced Nov 1, 2023
3 tasks
Joibel
added a commit
to Joibel/argo-workflows
that referenced
this pull request
Nov 3, 2023
The merge with argoproj#11451 reverted this, so this commit is just to reinstate that. The tests included in argoproj#11379 failed to catch this, I've raised argoproj#12129 for this, but in the interests of matching the documentation and kubecon next week I'm putting this PR in now. Fixes argoproj#12117 Signed-off-by: Alan Clucas <alan@clucas.org>
3 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please note: I am not totally in favour of this change, it makes memoization work without outputs and I'm not conviced this is actually healthy, but it's what people seem to expect. See the linked issues in the fixes list below.
This change will cause memoization to work for all step and dag tasks even without outputs. Note: They were working semi-erroneously for some dag tasks due to implicit outputs before this change.
Fixes #11280 (raised to cover this desire)
Fixes #10769 (already closed by documentation)
Partially addresses #10426: Dags will memoize now, but retries still won't - manually tested.