Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add guard against NodeStatus. Fixes #11102 #11451

Merged
merged 8 commits into from
Aug 1, 2023

Merge branch 'master' into upstream-nodestatus

d26a57c
Select commit
Loading
Failed to load commit list.
Merged

fix: add guard against NodeStatus. Fixes #11102 #11451

Merge branch 'master' into upstream-nodestatus
d26a57c
Select commit
Loading
Failed to load commit list.
DCO / DCO required action Aug 24, 2023 in 2s

DCO

There are 97 commits incorrectly signed off. This means that the author(s) of these commits failed to include a Signed-off-by line in their commit message.

To avoid having PRs blocked in the future, always include Signed-off-by: Author Name <authoremail@example.com> in every commit message. You can also do this automatically by using the -s flag (i.e., git commit -s).

Here is how to fix the problem so that this code can be merged.


Rebase the branch

If you have a local git environment and meet the criteria below, one option is to rebase the branch and add your Signed-off-by lines in the new commits. Please note that if others have already begun work based upon the commits in this branch, this solution will rewrite history and may cause serious issues for collaborators (described in the git documentation under "The Perils of Rebasing").

You should only do this if:

  • You are the only author of the commits in this branch
  • You are absolutely certain nobody else is doing any work based upon this branch
  • There are no empty commits in the branch (for example, a DCO Remediation Commit which was added using --allow-empty)

To add your Signed-off-by line to every commit in this branch:

  1. Ensure you have a local copy of your branch by checking out the pull request locally via command line.
  2. In your local branch, run: git rebase HEAD~250 --signoff
  3. Force push your changes to overwrite the branch: git push --force-with-lease origin upstream-nodestatus

Summary

Commit sha: aa2b66a, Author: Abraham Bah, Committer: GitHub; Expected "Abraham Bah 2195667+abrabah@users.noreply.github.com", but got "Abraham Bah abraham.bah@gmail.com".
Commit sha: 0ea1616, Author: Akashinfy, Committer: GitHub; The sign-off is missing.
Commit sha: 9a2bb5e, Author: Alan Clucas, Committer: GitHub; The sign-off is missing.
Commit sha: 2a5c4e8, Author: Alan Clucas, Committer: GitHub; The sign-off is missing.
Commit sha: 04d527c, Author: Alan Clucas, Committer: GitHub; The sign-off is missing.
Commit sha: 0ad4169, Author: Alan Clucas, Committer: GitHub; The sign-off is missing.
Commit sha: 476cd7a, Author: Alan Clucas, Committer: GitHub; The sign-off is missing.
Commit sha: 441f754, Author: Aleksandr Lossenko, Committer: GitHub; The sign-off is missing.
Commit sha: 8dbdc02, Author: Alexander Crow, Committer: GitHub; Expected "Alexander Crow crowcrow@users.noreply.github.com", but got "Alexander Crow acrow@akamai.com".
Commit sha: 2401be8, Author: Amit Oren, Committer: GitHub; Expected "Amit Oren github@amitoren.dev", but got "Amit Oren amit@coralogix.com".
Commit sha: 1bd3d9a, Author: Anton Gilgur, Committer: GitHub; The sign-off is missing.
Commit sha: 51c066f, Author: Anton Gilgur, Committer: GitHub; Expected "Anton Gilgur 4970083+agilgur5@users.noreply.github.com", but got "Anton Gilgur agilgur5@gmail.com".
Commit sha: 5f78733, Author: Anton Gilgur, Committer: GitHub; The sign-off is missing.
Commit sha: 48fb18e, Author: Anton Gilgur, Committer: GitHub; The sign-off is missing.
Commit sha: eb16431, Author: Anton Gilgur, Committer: GitHub; Expected "Anton Gilgur 4970083+agilgur5@users.noreply.github.com", but got "Anton Gilgur agilgur5@gmail.com".
Commit sha: 8ec5623, Author: Anton Gilgur, Committer: GitHub; The sign-off is missing.
Commit sha: 30a9168, Author: Anton Gilgur, Committer: GitHub; Expected "Anton Gilgur 4970083+agilgur5@users.noreply.github.com", but got "Anton Gilgur agilgur5@gmail.com".
Commit sha: 50395d2, Author: Anton Gilgur, Committer: GitHub; The sign-off is missing.
Commit sha: 28376e5, Author: Anton Gilgur, Committer: GitHub; The sign-off is missing.
Commit sha: 9264f76, Author: Anton Gilgur, Committer: GitHub; Expected "Anton Gilgur 4970083+agilgur5@users.noreply.github.com", but got "Anton Gilgur agilgur5@gmail.com".
Commit sha: 60cf512, Author: Anton Gilgur, Committer: GitHub; Expected "Anton Gilgur 4970083+agilgur5@users.noreply.github.com", but got "Anton Gilgur agilgur5@gmail.com".
Commit sha: 48ca7f8, Author: Anton Gilgur, Committer: GitHub; Expected "Anton Gilgur 4970083+agilgur5@users.noreply.github.com", but got "Anton Gilgur agilgur5@gmail.com".
Commit sha: 22d8461, Author: Anton Gilgur, Committer: GitHub; Expected "Anton Gilgur 4970083+agilgur5@users.noreply.github.com", but got "Anton Gilgur agilgur5@gmail.com".
Commit sha: 383bb6b, Author: Anton Gilgur, Committer: GitHub; Expected "Anton Gilgur 4970083+agilgur5@users.noreply.github.com", but got "Anton Gilgur agilgur5@gmail.com".
Commit sha: 8de568b, Author: Anton Gilgur, Committer: GitHub; The sign-off is missing.
Commit sha: 7f22085, Author: Anton Gilgur, Committer: GitHub; Expected "Anton Gilgur 4970083+agilgur5@users.noreply.github.com", but got "Anton Gilgur agilgur5@gmail.com".
Commit sha: 589a4b7, Author: Anton Gilgur, Committer: GitHub; The sign-off is missing.
Commit sha: 34ffc87, Author: Anton Gilgur, Committer: GitHub; Expected "Anton Gilgur 4970083+agilgur5@users.noreply.github.com", but got "Anton Gilgur agilgur5@gmail.com".
Commit sha: 0b85a64, Author: Anton Gilgur, Committer: GitHub; Expected "Anton Gilgur 4970083+agilgur5@users.noreply.github.com", but got "Anton Gilgur agilgur5@gmail.com".
Commit sha: 2d20532, Author: Anton Gilgur, Committer: GitHub; Expected "Anton Gilgur 4970083+agilgur5@users.noreply.github.com", but got "Anton Gilgur agilgur5@gmail.com".
Commit sha: eefa6ec, Author: Anton Gilgur, Committer: GitHub; Expected "Anton Gilgur 4970083+agilgur5@users.noreply.github.com", but got "Anton Gilgur agilgur5@gmail.com".
Commit sha: 0118429, Author: Anton Gilgur, Committer: GitHub; Expected "Anton Gilgur 4970083+agilgur5@users.noreply.github.com", but got "Anton Gilgur agilgur5@gmail.com".
Commit sha: 98acfb7, Author: Anton Gilgur, Committer: GitHub; Expected "Anton Gilgur 4970083+agilgur5@users.noreply.github.com", but got "Anton Gilgur agilgur5@gmail.com".
Commit sha: 20b5814, Author: Anton Gilgur, Committer: GitHub; Expected "Anton Gilgur 4970083+agilgur5@users.noreply.github.com", but got "Anton Gilgur agilgur5@gmail.com".
Commit sha: f8a34a3, Author: Byeonggon Lee, Committer: GitHub; Expected "Byeonggon Lee gonny952@gmail.com", but got "Byeonggon Lee binkoni@gonnux.com".
Commit sha: dc56332, Author: Carlos M, Committer: GitHub; Expected "Carlos M 1761056+cmontemuino@users.noreply.github.com", but got "carlosm carlos.montemuino@adyen.com".
Commit sha: 336d8a4, Author: Cayde6, Committer: GitHub; The sign-off is missing.
Commit sha: 7f155e4, Author: Cheng Wang, Committer: GitHub; Expected "Cheng Wang wangchengiscool@gmail.com", but got "astraw99 wangchengiscool@gmail.com".
Commit sha: e53a265, Author: DahuK, Committer: GitHub; The sign-off is missing.
Commit sha: d992ec5, Author: devops-42, Committer: GitHub; Expected "devops-42 32969215+devops-42@users.noreply.github.com", but got "Matthias Dietz m.dietz@ewerk.com".
Commit sha: 29d63c5, Author: Dylan Bragdon, Committer: GitHub; Expected "Dylan Bragdon 35122933+dbragdon1@users.noreply.github.com", but got "Dylan Bragdon dylan.bragdon@gmail.com".
Commit sha: 15d8463, Author: ehellmann-nydig, Committer: GitHub; Expected "ehellmann-nydig 89489125+ehellmann-nydig@users.noreply.github.com", but got "Eli Hellmann eli.hellmann@nydig.com".
Commit sha: acb3296, Author: Elifarley C, Committer: GitHub; Expected "Elifarley C 519940+elifarley@users.noreply.github.com", but got "Elifarley elifarley@gmail.com".
Commit sha: f385d23, Author: GoshaDozoretz, Committer: GitHub; Expected "GoshaDozoretz gosha@rookout.com", but got "Gosha gosha@rookout.com".
Commit sha: 97b6fa8, Author: gussan, Committer: GitHub; The sign-off is missing.
Commit sha: 869e42d, Author: gussan, Committer: GitHub; Expected "gussan 83329336+toyamagu-2021@users.noreply.github.com", but got "toyamagu2021@gmail.com toyamagu2021@gmail.com".
Commit sha: 5b31ca1, Author: gussan, Committer: GitHub; Expected "gussan 83329336+toyamagu-2021@users.noreply.github.com", but got "toyamagu2021@gmail.com toyamagu2021@gmail.com".
Commit sha: 5cb75d9, Author: gussan, Committer: GitHub; The sign-off is missing.
Commit sha: f5d41f8, Author: gussan, Committer: GitHub; The sign-off is missing.
Commit sha: 2016078, Author: Isitha Subasinghe, Committer: GitHub; Expected "Isitha Subasinghe isitha@pipekit.io", but got "isubasinghe isitha@pipekit.io".
Commit sha: bf6ce03, Author: Isitha Subasinghe, Committer: GitHub; The sign-off is missing.
Commit sha: e5dd864, Author: James Slater, Committer: GitHub; Expected "James Slater 844263+SlaterByte@users.noreply.github.com", but got "James Slater SlaterByte@users.noreply.github.com".
Commit sha: a8964d7, Author: Jason Meridth, Committer: GitHub; The sign-off is missing.
Commit sha: 3273709, Author: Jason Meridth, Committer: GitHub; The sign-off is missing.
Commit sha: 22d4e17, Author: Jinsu Park, Committer: GitHub; The sign-off is missing.
Commit sha: c6a2a4f, Author: Jinsu Park, Committer: GitHub; The sign-off is missing.
Commit sha: d4549b3, Author: Julie Vogelman, Committer: GitHub; Expected "Julie Vogelman julie_vogelman@intuit.com", but got "Julie Vogelmani julie_vogelman@intuit.com".
Commit sha: 6e97c7d, Author: Julie Vogelman, Committer: GitHub; The sign-off is missing.
Commit sha: 609539d, Author: Lan, Committer: GitHub; Expected "Lan gcslyp@gmail.com", but got "Lan Liang gcslyp@gmail.com".
Commit sha: 245af38, Author: Lucas Heinlen, Committer: GitHub; The sign-off is missing.
Commit sha: 97ae3bd, Author: Lukas Grotz, Committer: GitHub; Expected "Lukas Grotz lukasgrotz@gmail.com", but got "Transmitt0r lukasgrotz@gmail.com".
Commit sha: c9ebf42, Author: Lukas Wöhrl, Committer: GitHub; The sign-off is missing.
Commit sha: 8786b46, Author: Max Xu, Committer: GitHub; The sign-off is missing.
Commit sha: 944702e, Author: Max Xu, Committer: GitHub; The sign-off is missing.
Commit sha: 539a51e, Author: Max Xu, Committer: GitHub; The sign-off is missing.
Commit sha: 72c2672, Author: Mickaël Canévet, Committer: GitHub; The sign-off is missing.
Commit sha: 547c989, Author: Or Shachar, Committer: GitHub; The sign-off is missing.
Commit sha: 4225cb8, Author: Or Shachar, Committer: GitHub; Expected "Or Shachar or.shachar@wiz.io", but got "or-shachar or.shachar@wiz.io".
Commit sha: 90930ab, Author: Or Shachar, Committer: GitHub; Expected "Or Shachar or.shachar@wiz.io", but got "or-shachar or.shachar@wiz.io".
Commit sha: 6e209cd, Author: PanagiotisS, Committer: GitHub; Expected "PanagiotisS PanagiotisS@users.noreply.github.com", but got "Panagiotis Simatos mail@p-simatos.com".
Commit sha: 1e4a376, Author: PeterKoegel, Committer: GitHub; Expected "PeterKoegel 133140762+PeterKoegel@users.noreply.github.com", but got "Peter Kögel peter.koegel@vector.com".
Commit sha: abc4e8f, Author: Rachel Bushrian, Committer: GitHub; Expected "Rachel Bushrian rbushri@gmail.com", but got "rbushrian rbushrian@akamai.com".
Commit sha: 901549f, Author: Roel Arents, Committer: GitHub; Can not find "Roel Arents 2691308+roelarents@users.noreply.github.com", in ["Roel Arents roel.arents@kadaster.nl", "Dirc e.e.cornet@gmail.com"].
Commit sha: 082f063, Author: Roel Arents, Committer: GitHub; Expected "Roel Arents 2691308+roelarents@users.noreply.github.com", but got "Roel Arents roel.arents@kadaster.nl".
Commit sha: 137d5f8, Author: sakai-ast, Committer: GitHub; Expected "sakai-ast 35858151+sakai-ast@users.noreply.github.com", but got "sakai sakai.at24@gmail.com".
Commit sha: be0bdf9, Author: Saravanan Balasubramanian, Committer: GitHub; Expected "Saravanan Balasubramanian 33908564+sarabala1979@users.noreply.github.com", but got "Saravanan Balasubramanian sarabala1979@gmail.com".
Commit sha: 5294f35, Author: shuangkun tian, Committer: GitHub; Expected "shuangkun tian 72060326+shuangkun@users.noreply.github.com", but got "shuangkun tsk2013uestc@163.com".
Commit sha: b07de99, Author: Takumi Sue, Committer: GitHub; Expected "Takumi Sue 23391543+mikutas@users.noreply.github.com", but got "mikutas 23391543+mikutas@users.noreply.github.com".
Commit sha: 8b69e3e, Author: Tim Collins, Committer: GitHub; Expected "Tim Collins 45351296+tico24@users.noreply.github.com", but got "Tim Collins tim@thecollins.team".
Commit sha: b89c98b, Author: Tim Collins, Committer: GitHub; Expected "Tim Collins 45351296+tico24@users.noreply.github.com", but got "Tim Collins tim@thecollins.team".
Commit sha: 0994de6, Author: Tim Collins, Committer: GitHub; Expected "Tim Collins 45351296+tico24@users.noreply.github.com", but got "Tim Collins tim@thecollins.team".
Commit sha: af36f2d, Author: Tim Collins, Committer: GitHub; The sign-off is missing.
Commit sha: 36cefc9, Author: Tim Collins, Committer: GitHub; Expected "Tim Collins 45351296+tico24@users.noreply.github.com", but got "Tim Collins tim@thecollins.team".
Commit sha: bda5322, Author: Tom Kahn, Committer: GitHub; The sign-off is missing.
Commit sha: 019705e, Author: Tore, Committer: GitHub; Expected "Tore tore.lonoy@gmail.com", but got "Tore S. Loenoey tore.lonoy@gmail.com".
Commit sha: 0fd4227, Author: Tore, Committer: GitHub; Expected "Tore tore.lonoy@gmail.com", but got "Tore S. Loenoey tore.lonoy@gmail.com".
Commit sha: c1c3a5a, Author: toyamagu, Committer: GitHub; Expected "toyamagu 83329336+toyamagu-2021@users.noreply.github.com", but got "toyamagu2021@gmail.com toyamagu2021@gmail.com".
Commit sha: 0c5a6dd, Author: toyamagu, Committer: GitHub; Expected "toyamagu 83329336+toyamagu-2021@users.noreply.github.com", but got "toyamagu2021@gmail.com toyamagu2021@gmail.com".
Commit sha: d91b721, Author: vanny96, Committer: GitHub; Expected "vanny96 47816664+vanny96@users.noreply.github.com", but got "Giovanni Barbaro vanni-96@hotmail.it".
Commit sha: b231579, Author: wangxiang, Committer: GitHub; The sign-off is missing.
Commit sha: 32acb79, Author: weafscast, Committer: GitHub; The sign-off is missing.
Commit sha: ce9e50c, Author: younggil, Committer: GitHub; Expected "younggil zelord.kwoun@gmail.com", but got "zel0rd zelord.kwoun@gmail.com".
Commit sha: 1f6d1ba, Author: Yuan Tang, Committer: GitHub; The sign-off is missing.
Commit sha: 6120a2d, Author: Yuan Tang, Committer: GitHub; The sign-off is missing.
Commit sha: 7310e9c, Author: YunCow, Committer: GitHub; Expected "YunCow skypnal12@gmail.com", but got "Ycow skypnal12@gmail.com".
Commit sha: fd561eb, Author: Zubair Haque, Committer: GitHub; The sign-off is missing.
Commit sha: 12af30c, Author: 李杰穎 (Jay Lee), Committer: GitHub; Expected "李杰穎 (Jay Lee) jayin920805@gmail.com", but got "Jay Lee jayin920805@gmail.com".