feat: Use WorkflowTemplate/ClusterWorkflowTemplate Informers when validating CronWorkflows #11470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julie Vogelman <julievogelman0@gmail.com>
Signed-off-by: Julie Vogelman <julievogelman0@gmail.com>
Signed-off-by: Julie Vogelman <julievogelman0@gmail.com>
Signed-off-by: Julie Vogelman <julievogelman0@gmail.com>
juliev0
commented
Jul 28, 2023
| @@ -135,7 +135,7 @@ kind: ClusterWorkflowTemplate | |||
| metadata: | |||
| name: cluster-workflow-template-submittable | |||
| spec: | |||
| entryPoint: whalesay-template | |||
| entrypoint: whalesay-template | |||
| arguments: | |||
| parameters: | |||
There was a problem hiding this comment.
not related but this is a typo
Signed-off-by: Julie Vogelman <julievogelman0@gmail.com>
juliev0
commented
Jul 28, 2023
| } | ||
|
|
||
| func NewClusterWorkflowTemplateFromInformerGetter(cwftmplInformer wfextvv1alpha1.ClusterWorkflowTemplateInformer) templateresolution.ClusterWorkflowTemplateGetter { | ||
| return &ClusterWorkflowTemplateFromInformerGetter{cwftmplInformer: cwftmplInformer} | ||
| } |
There was a problem hiding this comment.
let me know if there's a better place to put this struct...
Signed-off-by: Julie Vogelman <julievogelman0@gmail.com>
Signed-off-by: Julie Vogelman <julievogelman0@gmail.com>
Signed-off-by: Julie Vogelman <julievogelman0@gmail.com>
juliev0
changed the title
Signed-off-by: Julie Vogelman <julievogelman0@gmail.com>
terrytangyuan
pushed a commit
that referenced
this pull request
Nov 27, 2023
…idating CronWorkflows (#11470) Signed-off-by: Julie Vogelman <julievogelman0@gmail.com>
dpadhiar
pushed a commit
to dpadhiar/argo-workflows
that referenced
this pull request
May 9, 2024
…idating CronWorkflows (argoproj#11470) Signed-off-by: Julie Vogelman <julievogelman0@gmail.com> Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>
agilgur5
added
area/controller
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11372
Motivation
When a CronWorkflow gets run it first gets validated. If it contains a WorkflowTemplate or CronWorkflowTemplate, it goes to the K8S API to get the spec to do the validation, rather than using what's already been stored locally in the Informer caches.
Modifications
Uses the WorkflowTemplate Informer and ClusterWorkflowTemplate Informer instead.
Verification