chore(deps): upgrade monaco-editor to 0.30
#11593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 0.30 requires `monaco-editor-webpack-plugin` 6, per the [version matrix](https://github.com/microsoft/monaco-editor/tree/v0.41.0/webpack-plugin#version-matrix) - [0.29.0](https://github.com/microsoft/monaco-editor/blob/v0.41.0/CHANGELOG.md#0290-08102021) had a breaking change to `renderIndentGuides`; converted to the new option - `true` might not be necessary as it's the default, but `guides` is empty by default, so not 100% sure -- left it in for now to ensure the behavior remains the same after the upgrade - 0.30 is the latest version I could upgrade to without requiring significant build changes - 0.31+ uses newer JS syntax per the [breaking changes](https://github.com/microsoft/monaco-editor/blob/v0.41.0/CHANGELOG.md#0310-10122021) - Per https://stackoverflow.com/a/70622999/3431180, this requires an updated parser, otherwise the Webpack build was getting similar errors as in the SO question - tried to remove `monaco-editor` from the `babel-loader` `exclude` to remedy this, but then the build would crash due to out-of-memory (OOM) heap allocation errors - as a result, only upgraded to 0.30 for now, can upgrade to latest once the build system is upgraded Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
agilgur5
added
type/dependencies
agilgur5
changed the title
monaco-editor to 0.30monaco-editor to 0.30
terrytangyuan
approved these changes
Aug 23, 2023
|
Did you verify that the editor still works? |
|
Oof that is a good question, I did not check that specifically. Most of my UI PRs modify the entire build, so build passing and just checking if the UI works is a decent verification, but this specific PR is actually for a very specific component of the UI. My bad, let me double check that now. I hadn't gotten the UI dev server connected to the back-end build before, so didn't get past a spot check |
|
Took a bit, but got all the builds working together on my local machine. Did need a small fix, see #11655 |
terrytangyuan
pushed a commit
that referenced
this pull request
Oct 19, 2023
Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
dpadhiar
pushed a commit
to dpadhiar/argo-workflows
that referenced
this pull request
May 9, 2024
Signed-off-by: Anton Gilgur <agilgur5@gmail.com> Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially replaces #11475, but there is still more work to be done as written below
Motivation
Was asked to help upgrade deps, particularly ones that may have vulns since Snyk opened #11475
Modifications
upgrade
monaco-editorto 0.30monaco-editor-webpack-plugin6, per the version matrixrenderIndentGuides; converted to the new optiontruemight not be necessary as it's the default, butguidesis empty by default, so not 100% sure -- left it in for now to ensure the behavior remains the same after the upgrade0.30 is the latest version I could upgrade to without requiring significant build changes
monaco-editorfrom thebabel-loaderexcludeto remedy this, but then the build would crash due to out-of-memory (OOM) heap allocation errorsVerification
Build passes, install succeeds