feat: upgrade expr to v1.14 for richer language definition #11605
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Updates antonmedv/expr from v1.13 to v1.14 which has a much richer language definition and includes useful helpers such as
hasPrefix
,max
I think this will really help with simplifying workflows. I also think it will make the WorkflowEventBinding much more useful and reduce the need for argo-events webhook eventsource.
The other problem that this will solve is that our docs constantly refer to the expr project to see how to write expressions. But if we continue to use the old version, users will hit unexpected errors. e.g.:
In fact, this is how I discovered the new version in the first place (I was confused on why certain functions were unavailable).