feat: add default metric of argo_pod_missing #11857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So sorry, I'm going through old PRs and I see that unfortunately this one has been forgotten. I will try to review it soon. Argo Workflows needs more people approving PRs unfortunately. If your company is by chance interested, I am gauging interest in this idea: #12229 |
juliev0
reviewed
Dec 5, 2023
Signed-off-by: moonyoungCHAE <xpf_fl@naver.com>
Signed-off-by: moonyoungCHAE <xpf_fl@naver.com>
juliev0
approved these changes
Dec 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11856
Motivation
argo_pod_missinghas no default value. It should have a zero value as all the other default metric.Modifications
I added zero when operator reconcile pod.
Verification