fix: suppress error about unable to obtain node #12020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikutas
force-pushed
the
suppress-invalid-error-log
branch
2 times, most recently
from
bb9455f
to
efdac5b
Compare
Signed-off-by: mikutas <23391543+mikutas@users.noreply.github.com>
mikutas
force-pushed
the
suppress-invalid-error-log
branch
from
efdac5b
to
618f180
Compare
terrytangyuan
approved these changes
Oct 19, 2023
|
@terrytangyuan Thank you for reviewing! Please retry required |
terrytangyuan
pushed a commit
that referenced
this pull request
Oct 19, 2023
Signed-off-by: mikutas <23391543+mikutas@users.noreply.github.com>
terrytangyuan
pushed a commit
that referenced
this pull request
Nov 3, 2023
Signed-off-by: mikutas <23391543+mikutas@users.noreply.github.com>
This was referenced Nov 4, 2023
dpadhiar
pushed a commit
to dpadhiar/argo-workflows
that referenced
this pull request
May 9, 2024
Signed-off-by: mikutas <23391543+mikutas@users.noreply.github.com> Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #11451
Motivation
After upgrading to v3.4.11, the error log is often reported from monitoring.
Modifications
When boundaryID is empty, we don't try to get node and also don't raise any error.
Verification