chore(deps): use official versions of bufpipe and expr
#12033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `expr`'s main fork is back after being temporarily down from GH, so return to using that - `bufpipe` [v1.0.4](https://github.com/acomagu/bufpipe/releases/tag/v1.0.4) added an MIT License - it seems to have applied it to the whole history, but only the newest GH release has it (which is v1.0.4) - this is an indirect dependency, but FOSSA found it and flagged it as unlicensed: https://app.fossa.com/projects/git%2Bgit.luolix.top%2Fargoproj%2Fargo-workflows/refs/branch/master/165f57fd1b40256cdd41c41cf3fc2b9e4664c9fe/issues/licensing?page=1&count=20&sort=created_at_desc&status=active&filter%5Btype%5D%5B0%5D=unlicensed_dependency&revisionScanId=47384451 - `go-git` uses it, but since we've had some issues with `go-git` and artifacts in the past, I didn't touch it for now ```sh $ go mod why -m github.com/acomagu/bufpipe github.com/argoproj/argo-workflows/v3/workflow/artifacts/git github.com/go-git/go-git/v5 github.com/go-git/go-git/v5/utils/ioutil github.com/acomagu/bufpipe ``` Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
agilgur5
added
type/dependencies
This was referenced Oct 18, 2023
|
Thanks. I was planning to do this today. The author's account is back and I have confirmed with him personally that he's planning to keep the repo under |
terrytangyuan
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #12032; there was a license issue that was picked up
Revert of #11971 now that
antonmedv/expris backMotivation
expr's main fork is back after being temporarily down from GH, so return to using thatbufpipev1.0.4 added an MIT LicenseFOSSA screenshot:
go-gituses it, but since we've had some issues withgo-gitand artifacts in the past (feat: replace go-git usage with git binary #10763, fix: use upstream go-git. Fixes #10091 #11149 etc), I didn't touch it for nowgo-gitwould resolve this as well, see Argo CD PR: chore(deps): bump github.com/go-git/go-git/v5 from 5.4.2 to 5.6.1 argo-cd#12907see
go mod whyoutput:Modifications
go.modforexprandbufpipeand rango mod tidyfor thego.sumresultsVerification
Ran
go mod tidy. Otherwise there are no semantic changes in the deps